Astroid 2.2 and Python 3.8 test failures #28
Comments
|
I get the same failures with Python 3.7. It's the asttokens version where things started to differ. I'll try to find out which. |
|
The failures start with astroid 2.2. |
|
I wrote PR #29 to "Fix some Python 3.8 issues". |
|
I added a commit on master which fixes the issues caused by astroid 2.2 |
|
With the patch (git master at 21caaaa), tests pass with python3-astroid-2.2.5-1.fc30.noarch.rpm + python3-3.7.3-1.fc30.x86_64.rpm and python3-astroid-2.2.5-2.fc31.noarch + python3-3.7.3-2.fc31.x86_64 but fail with python3-3.8.0~a3-1.fc31.x86_64 + python3-astroid-2.2.5-2.fc31.noarch. Thus, it seems that compat with astroid is done, but compat with python3.8 not yet. |
|
Here is the output with Python 3.8 on 21caaaa: |
|
This is due to python/cpython#9445
|
|
#29 addresses it, I think it can be simplified a bit, but it’s close.
…On Sat, May 4, 2019 at 12:16 PM Miro Hrončok ***@***.***> wrote:
This is due to python/cpython#9445
<python/cpython#9445>
Class ast.Constant is now used for all constants. Old classes ast.Num,
ast.Str, ast.Bytes, ast.NameConstant and ast.Ellipsis are still
available, but they will be removed in future Python releases.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIKMR3CO4HNMB3CZBHELTTPTWZF7ANCNFSM4HEJKL7Q>
.
|
keszybz
added a commit
to keszybz/asttokens
that referenced
this issue
Jun 18, 2019
This fixes some test failures under python3.8. All tests still pass on python3.7. Partially addresses gristlabs#28, replaces gristlabs#29. As suggested in https://github.com/gristlabs/asttokens/pull/29/files#r280123329.
keszybz
added a commit
to keszybz/astroid
that referenced
this issue
Jun 18, 2019
It is stored as a Constant, not a Str, so we the the value a bit differently. Fixes one test failure in gristlabs/asttokens#28.
dsagal
pushed a commit
that referenced
this issue
Jun 19, 2019
This fixes some test failures under python3.8. All tests still pass on python3.7. Partially addresses #28, replaces #29. As suggested in https://github.com/gristlabs/asttokens/pull/29/files#r280123329.
PCManticore
pushed a commit
to pylint-dev/astroid
that referenced
this issue
Jul 6, 2019
It is stored as a Constant, not a Str, so we the the value a bit differently. Fixes one test failure in gristlabs/asttokens#28.
|
It's a bit better now, but many failures still: |
|
Anything we can do from the Fedora side to move this forward? I'd be happy to provide a test environment with all the packages installed to make debugging easier. |
|
Python 3.8.0rc1 is out, which is supposed to mean no more code changes. The official release is expected in 2 weeks. Many tests are still failing on 3.8 that are unrelated to astroid. Can we change the title to "Astroid 2.2 and Python 3.8 test failures"? Is there any work currently being done on this? I'm planning to take a crack at it soon, but I haven't actually worked with this codebase before. |
dsagal
changed the title
|
It looks doable, I'll give it a shot this week. |
This was referenced Oct 4, 2019
Merged
|
This can be closed now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The test suite fails with Python 3.8.0a3:
On c8697dc with:
The text was updated successfully, but these errors were encountered: