Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Implement PUT and DELETE for columns #601

Closed
fflorent opened this issue Jul 31, 2023 · 3 comments · Fixed by #640
Closed

API: Implement PUT and DELETE for columns #601

fflorent opened this issue Jul 31, 2023 · 3 comments · Fixed by #640
Labels
anct

Comments

@fflorent
Copy link
Collaborator

Currently, the /columns api lacks of PUT (AddOrUpdate) and DELETE methods, which could be handy on some situations.
@fflorent fflorent added the anct label Jul 31, 2023
@fflorent
Copy link
Collaborator Author

fflorent commented Jul 31, 2023 •
edited
Loading

@paulfitz I started working on this, with the hope to implement a POC for issue #416 (an external program which would synchronize tables using the API).

However, I faced this error while using ops.upsert() on meta-table _grist_Tables_column: BulkAddOrUpdateRecord cannot yet be used on metadata tables. The exception is raised in GranularAccess#_checkAddOrUpdateAccess

Are BulkAddRecord and BulkUpdateRecord concerned by this limitation too?

fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Jul 31, 2023
@fflorent
WIP: implement PUT for columns gristlabs#601
bec2a4c
@fflorent
Copy link
Collaborator Author

Sorry, my question is dumb, they seem not to be concerned:

grist-core/app/server/lib/GranularAccess.ts

Line 1219 in e1df603

if (!scanActionsRecursively(actions, isAddOrUpdateRecordAction)) {

Please ignore my previous message :)

@paulfitz
Copy link
Member

Ignoring your message, and glad that you are working in this area.

fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 1, 2023
@fflorent
Working version of PUT gristlabs#601
98b5acf
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 1, 2023
@fflorent
Improve tests for PUT gristlabs#601
cffce13
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
Add noadd and noupdate options gristlabs#601
7295ec2
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
Improve implementation gristlabs#601
6c7a232
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
Ensure the viewers cannot edit columns gristlabs#601
0404940
fflorent added a commit to fflorent/grist-help that referenced this issue Aug 2, 2023
@fflorent
API - Update API doc to add PUT on columns
1f91993 
gristlabs/grist-core#601
@fflorent fflorent mentioned this issue Aug 2, 2023
Merged
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
Fix lint gristlabs#601
956949a
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
WIP: implement PUT for columns gristlabs#601
661ac64
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
Working version of PUT gristlabs#601
54330f9
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
Improve tests for PUT gristlabs#601
ada19ac
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
Add noadd and noupdate options gristlabs#601
a237e9b
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
Improve implementation gristlabs#601
76a4790
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
Ensure the viewers cannot edit columns gristlabs#601
2926011
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
Fix lint gristlabs#601
5620e8e
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 2, 2023
@fflorent
Fix lint gristlabs#601
fd0f0bf
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 3, 2023
@fflorent
Improve code for replaceall a little bit gristlabs#601
6efe8ac
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 3, 2023
@fflorent
Add test to cover error on non-existing table gristlabs#601
e1726e5
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 8, 2023
@fflorent
Test failing with rules updated gristlabs#601
fda013f
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 8, 2023
@fflorent
Test failing with rules updated gristlabs#601
2656d55
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 9, 2023
@fflorent
Remarks regarding the implementation gristlabs#601
7f3a598
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 9, 2023
@fflorent
Remarks regarding the implementation gristlabs#601
70a338d
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Remove forgotten console.log gristlabs#601
4eba055
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Add includeHidden param for GET on columns gristlabs#601
bda7abf
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
WIP: implement PUT for columns gristlabs#601
44d79a7
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Working version of PUT gristlabs#601
81ec264
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Improve tests for PUT gristlabs#601
9cf889e
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Add noadd and noupdate options gristlabs#601
5dfd9e9
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Improve implementation gristlabs#601
e6674ee
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Ensure the viewers cannot edit columns gristlabs#601
d7ed4c3
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Fix lint gristlabs#601
a8beae3
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Improve code for replaceall a little bit gristlabs#601
873a510
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Add test to cover error on non-existing table gristlabs#601
057ad60
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Remarks regarding the implementation gristlabs#601
135f550
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Remove forgotten console.log gristlabs#601
6f56582
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Add includeHidden param for GET on columns gristlabs#601
f647f1e
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 10, 2023
@fflorent
Add includeHidden param for GET on columns gristlabs#601
2956a9e
alexmojaki pushed a commit that referenced this issue Aug 11, 2023
@fflorent
Issue #601: implement PUT on columns (#605)
e93ad5a 
* Also Add includeHidden param for GET on columns
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 22, 2023
@fflorent
DocApi: Implement DELETE on columns (gristlabs#601)
7cdaaf7
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 22, 2023
@fflorent
DocApi: Implement DELETE on columns (gristlabs#601)
0fe2af2
@fflorent fflorent mentioned this issue Aug 22, 2023
Merged
fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Aug 23, 2023
@fflorent
DocApi: Implement DELETE on columns (gristlabs#601)
250788d
alexmojaki pushed a commit that referenced this issue Aug 24, 2023
@fflorent
DocApi: Implement DELETE on columns (#601) (#640)
ee31764 
* Factorize generateDocAndUrl
* Add describe for regrouping /records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
anct
Projects
French administration Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DocApi: Implement DELETE on columns (#601) incubateur-territoires/grist-core
2 participants
@paulfitz @fflorent