Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new translations #1004

Merged
merged 2 commits into from
May 29, 2024

Conversation

CamilleLegeron
Copy link
Collaborator

No description provided.

@CamilleLegeron CamilleLegeron marked this pull request as draft May 29, 2024 15:39
@CamilleLegeron CamilleLegeron changed the title feat: add new traductions feat: add new translations May 29, 2024
@CamilleLegeron CamilleLegeron self-assigned this May 29, 2024
@CamilleLegeron CamilleLegeron marked this pull request as ready for review May 29, 2024 15:42
@SleepyLeslie
Copy link
Collaborator

I might be missing some context, but apart from "Manage Team" and "Billing Account", are the newly added translations actually used in the code?

Copy link
Contributor

@georgegevoian georgegevoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CamilleLegeron!

@georgegevoian
Copy link
Contributor

I might be missing some context, but apart from "Manage Team" and "Billing Account", are the newly added translations actually used in the code?

The changes in en.client.json? Those are auto-generated from a script, I believe. They are indeed used in the code (looks like almost all of them are related to recent changes to the admin panel).

@georgegevoian georgegevoian merged commit 5956c20 into gristlabs:main May 29, 2024
15 checks passed
hexaltation pushed a commit to hexaltation/grist-core that referenced this pull request Jun 12, 2024
CamilleLegeron added a commit to incubateur-territoires/grist-core that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants