Remove messytables dependency from xlsx import #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step after #265.
Some points to notice, and to be discussed/arbitrated:
complex()
call from_is_numeric
helper, ascomplex("j")
returns True, and I'm not exactly sure how to work around this and how much it's important to recognize a complex number hereWith the
complex
check, this table headers will not be recognized (becausej
is a valid complex value):headers_guess
from messytable, and not our own version.With our version this table:
Will be imported with
Title,,
as headers, instead ofA,B,C
.test_excel_single_merged_cell
output table is not respected, and I'm not sure to understand exactly if the first structure was explicitly expected or not, so I'll need some lights hereHere is the fixture table:
Before:
After:
Thanks in advance for your feedback!
cc @alexmojaki