Linkstate flydev #565
Closed
Linkstate flydev #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds JV object to global namespace, adds pretty-printing methods for columns, links, sections, etc Shows linking debug info in rightPanel Adds debug window to topleft
Values are hacked together in buildViewSectionDom
Combined simpleFilter and srcCellFilter (the advantage of simpleFilter (that we don't need to look at any values) is gone once we need to start making labels, so it's more straightforward to unify them Still somewhat hacky with srcCol tgtCol vs srcColId vs tgtColId, we don't pass them into makeFilterObs right now, so the code just grabs them from this.srcCol and this.dstCol, but that won't work for summary tables, so still need to generalize
Filter bubbles now work correctly for unloaded tables and stuff
css mask-image vs -webkit-mask-image
If visibleCol is rowId, that's implemented as visibleCol = colRec 0, so its colId is undefined. Added an explicit check to fix that TODO: switch to using undefined instead of "id" in makeFilterObs and in makeValGetter to better mesh with grist style
Was trying to switch sections WITHOUT opening rename widget, but was clicking directly on .test-viewsection-title instead of -viewsection-blank, which exists for that purpose, so test broke
I previously changed lookup links (i.e. ref col -> row) to behave consistently whether ref or reflist. i.e.: instead of ref being a cursor-link and reflist filtering, they now both filter, so ref just shows a single record However this breaks tests so let's undo it temporarily
|
Deployed as https://grist-linkstate-flydev.fly.dev (until 2023-08-06T20:03:57.288Z) |
|
Deployed as https://grist-linkstate-flydev.fly.dev (until 2023-08-09T21:38:04.084Z) |
Works, but code is ugly
Handle '- blank -' selector values better
Changed colId == "id" to be colId == undefined. Works better with the col 0.colId == undefined that you get when you're passed in a non-null column but it's the "empty" column
Don't actually check, since in page widget the table doesn't exist yet, and I don't wanna deal with turning col ids to col models
|
Deployed as https://grist-linkstate-flydev.fly.dev (until 2023-08-09T21:58:00.466Z) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linkstate preview take 2
Fixed various bugs