Linux-specific fonts: Liberation Sans #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, ubuntu has a lot of issues with fonts. Both the regular font-family and the data-font-family end up evaluating to NimbusSans on my system (ubuntu's fallback font from helvetica) NimbusSans unfortunately is noticably too high, cause text in buttons, emoji on the left pane, and other vertical text alignment to be too high This diff explicitly says to use DejaVu and Liberation Sans which should have no effect on windows/mac systems, but should significantly improve appearance on ubuntu (and hopefully other linuxes) Both of these fonts are some of the more widely supported linux fonts, see: https://www.webfx.com/blog/web-design/a-web-designers-guide-to-linux-fonts/
|
Deployed as https://grist-ubuntu-fontfix2.fly.dev (until 2023-08-12T14:49:43.829Z) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specified linux-specific font "Liberation Sans", fixes vertical alignment in buttons/pills/column headers/emoji.
Previously we had Mac- and Windows-specific fonts, but Linux systems didn't have anything explicitly selected until they fell through to Helvetica, which by default got rendered in "Nimbus Sans" (at least on my ubuntu system). Unfortunately, Nimbus Sans is horribly vertically misaligned.
The previous iteration of this patch used DejaVu Sans for most text and Liberation Sans only for data in grids. This version uses liberation sans for all fonts, which fixes the too-wide issue that DejaVu had)
Screenshot with Liberation Sans
For comparison, old grist which defaulted to Nimbus Sans (BAD)
