Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor out low-dependency browser test code useful for grist-widget #576

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

paulfitz
Copy link
Member

It would be useful to write browser tests that use Grist for some of our other repositories (e.g. grist-widget, grist-static). This is a first baby step to factor out some useful code that has no code dependencies beyond mocha-webdriver, for use in grist-widget.

Initially I'm hoping to get away with just copying the code (see gristlabs/grist-widget#51); at some point it would more usefully be a library.

It would be useful to write browser tests that use Grist for some
of our other repositories (e.g. grist-widget, grist-static).
This is a first baby step to factor out some useful code that has
no code dependencies beyond mocha-webdriver, for use in grist-widget.
@paulfitz paulfitz marked this pull request as draft July 17, 2023 07:35
@paulfitz paulfitz marked this pull request as ready for review July 20, 2023 19:29
Copy link
Contributor

@georgegevoian georgegevoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulfitz.

@paulfitz paulfitz merged commit b054594 into main Jul 21, 2023
11 checks passed
@paulfitz paulfitz deleted the paulfitz/factor-out-some-test-code branch July 21, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants