Header colored

[CamilleLegeron]

Context

#320

Content

The style of header in GridView

We could rename the file CellStyle.ts by ColumnStyle.ts but it would break the translation. Or we could create an HeaderStyle.ts new file and use the css style are in the CellStyle.ts file.

[CamilleLegeron]

Two problems remain :

• when we select a color for a column header and we cancel the choice the color remains, until we reload the page. This problem appends only for color and background color (see the gif)
• when we select a cell with no header background color, the background color doesn't change. The style .column_name.selected in viewCommon.css file works halfway

[CamilleLegeron]

Should I only add tests in the nbBrowser/MultiColumn.ts file, or are there any other tests you'd like to add before validating this PR?

[georgegevoian]

Two problems remain :

• when we select a color for a column header and we cancel the choice the color remains, until we reload the page. This problem appends only for color and background color (see the gif)
• when we select a cell with no header background color, the background color doesn't change. The style .column_name.selected in viewCommon.css file works halfway

I believe the second one is happening because --grist-header-color and --grist-header-background-color are set to undefined, which is treated as defined when CSS custom properties are evaluated, so the fallbacks don't get used. Changing it so that those properties are not set at all on the element should fix it.

I haven't been able to reproduce the first one so far. Seems to be working ok for me?

[georgegevoian]

Should I only add tests in the nbBrowser/MultiColumn.ts file, or are there any other tests you'd like to add before validating this PR?

I'd say one test in MultiColumn.ts similar to the one for cell styles, and a couple of new tests in a new file, HeaderStyles.ts, that check the basic behavior would be good.

There's already some utils in gristUtils.ts for checking cell styles that you may be able to adapt to work with header styles too, if you'd like. We have some tests for cell styles that aren't yet in this repo that we'll try to get moved over by next week; tests for header styles should be very similar, so if you can wait a little bit, you can reuse those for the new tests.

[CamilleLegeron]

thanks @georgegevoian, I added tests and correct the little error I had.
I set my PR to ready

[georgegevoian]

Thanks for opening the PR @CamilleLegeron.

I left some comments and suggestions.

[georgegevoian]

Thanks for addressing the comments.

The TypeChange test failures are unrelated so you can ignore them. (We're working on a fix.)

[georgegevoian]

Thanks @CamilleLegeron!

Will merge once the MultiColumn tests are passing. (I think it's just the fill color that needs to be changed.)