REQUEST with unknown and undetectable encoding #600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #599 , where the
encoding
parameter was not always passed to Response.It also includes a workaround for another issue, where the encoding cannot be determined by the existing JS implementation or the Python implementation. Since the most common case of this may be an empty response, with no useful response headers for determining the encoding, I figure that any encoding will do, so I used utf-8 as a default.