Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST with unknown and undetectable encoding #600

Merged

Conversation

johncant
Copy link
Contributor

This fixes issue #599 , where the encoding parameter was not always passed to Response.

It also includes a workaround for another issue, where the encoding cannot be determined by the existing JS implementation or the Python implementation. Since the most common case of this may be an empty response, with no useful response headers for determining the encoding, I figure that any encoding will do, so I used utf-8 as a default.

Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johncant

@paulfitz paulfitz merged commit 5738019 into gristlabs:main Aug 2, 2023
13 checks passed
@johncant johncant deleted the feature/fix_REQUEST_unknown_encoding branch August 2, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants