Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak XLSX export worker to make Piscina happy under Electron #646

Merged
merged 1 commit into from
Aug 28, 2023

Commits on Aug 27, 2023

  1. tweak XLSX export worker to make Piscina happy under Electon

    Adds a dummy default export to the worker exporter script used
    for producing XLSX. This method exists only to make Piscina
    happier. With it, Piscina will load this file using a regular
    require(), which under Electron will deal fine with Electron's
    ASAR app bundle. Without it, Piscina will try fancier methods
    that aren't at the time of writing correctly patched to
    deal with an ASAR app bundle, and so report that this
    file doesn't exist instead of exporting an XLSX file.
    
    I tried various other solutions such as upgrading Electron,
    unpacking various files, patching Piscina, and this was
    overall the simplest.
    
    See gristlabs/grist-desktop#9
    paulfitz committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    e892a89 View commit details
    Browse the repository at this point in the history