Support nonce and acr with OIDC + Tests #883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflorent
force-pushed
the
support-nonce-and-acr-with-oidc
branch
3 times, most recently
from
e78e2f3
to
8b90c90
Compare
fflorent
commented
Mar 19, 2024
|
Opening the PR for checking whether the tests work in the CI |
fflorent
changed the title
fflorent
force-pushed
the
support-nonce-and-acr-with-oidc
branch
21 times, most recently
from
56706b3
to
1bf114a
Compare
fflorent
changed the title
fflorent
force-pushed
the
support-nonce-and-acr-with-oidc
branch
from
3603767
to
bb6445b
Compare
fflorent
commented
Jul 25, 2024
| @@ -167,33 +224,43 @@ export class OIDCConfig { | |||
| profile, | |||
| })); | |||
|
|
|||
| delete mreq.session.oidc; | |||
| mreq.session.oidc = { | |||
There was a problem hiding this comment.
Is what I wrote good to you?
app/server/lib/OIDCConfig.ts
Outdated
| res.redirect(targetUrl ?? '/'); | ||
| } catch (err) { | ||
| log.error(`OIDC callback failed: ${err.stack}`); | ||
| // Delete the session data even if the login failed. | ||
| if (Object.prototype.hasOwnProperty.call(err, 'response')) { | ||
| log.error(`Response received: ${err.response?.body ?? err.response}`); |
There was a problem hiding this comment.
I realized that the error may be multiple things (especially the body may be a buffer).
I made some changes, with the hope it will be fine for you. If that's too tricky or you feel a bit uncomfortable, I may remove this log and reintroduce it a bit later or in a separate PR.
fflorent
force-pushed
the
support-nonce-and-acr-with-oidc
branch
from
561dc45
to
15732bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Proposed solution
GRIST_OIDC_IDP_ENABLED_PROTECTIONSvariable who can contain comma-separated values with either:STATE,NONCEandPKCE, and defaults toSTATE,PKCE;GRIST_OIDC_IDP_ACR_VALUESvariable with space separated values;