Bump dependencies versions #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflorent
force-pushed
the
bump-dependencies
branch
3 times, most recently
from
65f6af4
to
dbc4c34
Compare
fflorent
force-pushed
the
bump-dependencies
branch
5 times, most recently
from
e9dd443
to
168f739
Compare
berhalak
reviewed
Apr 12, 2024
fflorent
force-pushed
the
bump-dependencies
branch
from
168f739
to
0e2c601
Compare
fflorent
commented
Apr 17, 2024
| if (ev.lengthComputable) { | ||
| progress.setUploadProgress(ev.loaded / ev.total * 100); // percentage complete | ||
| function onUploadProgress(ev: AxiosProgressEvent) { | ||
| if (ev.event.lengthComputable) { |
There was a problem hiding this comment.
FWIW, I achieved to hit a breakpoint here. The workspaceId equals to "unsaved" when the user is not logged in but is allowed to upload documents (temporary).
I could inspect the properties of ev.event and they have consistent values.
jordigh
approved these changes
Apr 24, 2024
| catw app/client/*.css app/client/*/*.css -o static/bundle.css -v & webpack --config $WEBPACK_CONFIG --mode development --watch & | ||
| css_files="app/client/**/*.css" | ||
| chokidar "${css_files}" -c "bash -O globstar -c 'cat ${css_files} > static/bundle.css'" & | ||
| webpack --config $WEBPACK_CONFIG --mode development --watch & |
There was a problem hiding this comment.
This is a pretty cool way to replace the abandoned catw package.
|
@jordigh Thanks for your review. Do you wait for another review before merging? Otherwise I do not have the rights to merge myself. |
|
@fflorent I need to first verify deploying to our own Grist SAAS before I merge. |
|
@jordigh Sounds good! 👍 |
|
Thanks for your patience. After some internal testing, we are satisfied with the state of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.