Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin API docs with new FetchSelectedOptions, plus minor fixes #297

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

alexmojaki
Copy link
Collaborator

@alexmojaki alexmojaki commented Jan 4, 2024

Following up on gristlabs/grist-core@4e67c67, rebuilds the plugin API docs to include the new FetchSelectedOptions added in that commit.

While I was at it, I made https://phab.getgrist.com/D4155 to fix some errors emitted by ./build-plugin-api.sh, the resulting fixes are also reflected here.

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for grist-help-preview ready!

Name Link
🔨 Latest commit e2d79bb
🔍 Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/65968b15c68f760008c50fce
😎 Deploy Preview https://deploy-preview-297--grist-help-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexmojaki alexmojaki marked this pull request as ready for review January 4, 2024 10:48
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I squinted at this quite a bit and didn't notice any problems. Thank you @alexmojaki

@alexmojaki alexmojaki merged commit 5a8e160 into master Jan 4, 2024
5 checks passed
fflorent pushed a commit to fflorent/grist-help that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants