Open Record Card on Calendar event click #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boisterous-sunburst-a5c941 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
georgegevoian
changed the title
berhalak
approved these changes
Feb 2, 2024
| @@ -218,6 +218,7 @@ class CalendarHandler { | |||
| TZDate = this.calendar.getDate().constructor; | |||
|
|
|||
| this.calendar.on('clickEvent', async (info) => { | |||
| focusWidget(); | |||
There was a problem hiding this comment.
Without this, the calendar widget doesn't get focus if you click or double-click an event. This breaks the new viewAsCard command because it opens the selected record in the active section, and if the calendar isn't the active section, the wrong record is shown in the popup.
berhalak
approved these changes
Feb 12, 2024
jperon
pushed a commit
to jperon/grist-widget
that referenced
this pull request
Feb 14, 2024
jperon
pushed a commit
to jperon/grist-widget
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New test will fail temporarily until the Grist image is updated with support for opening a Record Card from a custom widget.