Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make map source configurable #126

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

jperon
Copy link
Contributor

@jperon jperon commented Mar 14, 2024

To make it easier to change map source. For example, (and to test), those values work:

https://tile.openstreetmap.org/{z}/{x}/{y}.png
&copy; <a href="https://openstreetmap.org/copyright">OpenStreetMap contributors</a>

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for boisterous-sunburst-a5c941 ready!

Name Link
🔨 Latest commit 297f194
🔍 Latest deploy log https://app.netlify.com/sites/boisterous-sunburst-a5c941/deploys/65f3842f04b2640008f70a20
😎 Deploy Preview https://deploy-preview-126--boisterous-sunburst-a5c941.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hosios
Copy link

hosios commented Mar 14, 2024

I just tried it and it worked perfectly. I would suggest and vote for the merge.

@kamazeuci
Copy link

this would be wonderful

Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very sorry we dropped the ball on landing this earlier. Thanks @jperon, and @hosios @kamazeuci for nudges!

@paulfitz paulfitz merged commit 12244c9 into gristlabs:master May 9, 2024
1 of 2 checks passed
@kamazeuci
Copy link

it's working beautifully! thanks!!

@kamazeuci
Copy link

oops! nope... I mean, it is working, but if you close the map (for example by choosing a new table), then open the map back again, it goes back to ESRI map.
In other words, the Map configuration is not saved.

@jperon
Copy link
Contributor Author

jperon commented May 10, 2024

oops! nope... In other words, the Map configuration is not saved.

Did you click the green « Save » after editing the option ?

@kamazeuci
Copy link

Oh I see... no, that button is not rendered for me... but when I hover the cursor over the top left corner of the dialogue, it shows a hand so I suppose that is the save button. thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants