Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem accent windows client #765

Open
jacky35 opened this issue Oct 15, 2018 · 18 comments
Open

Problem accent windows client #765

jacky35 opened this issue Oct 15, 2018 · 18 comments

Comments

@jacky35
Copy link

jacky35 commented Oct 15, 2018

Hello,
I have a problem with a user who uses accents in his name.
The Burp Client refuses to make a backup.

2018-10-15 18:19:09 +0200: burp[13091] Backup started
2018-10-15 18:19:09 +0200: burp[13091] Client version: 2.2.12
2018-10-15 18:19:28 +0200: burp[13091] WARNING: Could not stat C:/Users/Rémi/Desktop: Unknown error
2018-10-15 18:19:28 +0200: burp[13091] WARNING: Could not stat C:/Users/Rémi/Documents: Unknown error

@ziirish
Copy link
Contributor

ziirish commented Oct 15, 2018

Is the include defined client side?
I was never able to make this work thanks to Windows and its wonderful i18n support.
Anyway, that's why I implemented the include_wildcard option.

Another way to workaround this issue is to define your include server-side.

@jacky35
Copy link
Author

jacky35 commented Oct 15, 2018

It is defined server side.

By cons, I currently use the option "include_glob": - /

include_glob = C:/Users//Desktop
include_glob = C:/Users/
/Documents
include_glob = C:/Users//AppData/Roaming/Thunderbird
include_glob = C:/Users/
/AppData/Roaming/Mozilla

@ziirish
Copy link
Contributor

ziirish commented Oct 16, 2018

Yes sorry, I meant include_glob instead of include_wildcard.
Doesn't this workaround your issue?

@jacky35
Copy link
Author

jacky35 commented Oct 16, 2018

Hello,
From the beginning I use a configuration on the server .

I have a file. incexc / profile_poste_windows_standard
on the server with:


include_glob = C:/Users//Desktop
include_glob = C:/Users/
/Documents
include_glob = C:/Users//AppData/Roaming/Thunderbird
include_glob = C:/Users/
/AppData/Roaming/Mozilla

exclude_regex="C:/Users/Administrateur"
exclude_regex="C:/Users/Administrator"
exclude_regex="C:/Users/Default"
exclude_regex="C:/Users/Default User"
exclude_regex="C:/Users/Public"
exclude_regex="C:/Users/All Users"

exclude_regex = /PrivÃe/
exclude_regex = /Private/
exclude_regex = /perso/
exclude_regex = /PERSONNEL/
exclude_regex = /privee/

exclude_regex = /ImapMail/

strip_vss = 1
~-------

Here is an attachment of the client's backup file:
http://dl.free.fr/qzLgpPGgf


@jacky35
Copy link
Author

jacky35 commented Oct 16, 2018

Am i oblige to do it manually for this client
a specific include_glob as below :

include_blog = C:/Users/Rémi/Desktop
include_blog = C:/Users/Rémi/Documents

@ziirish
Copy link
Contributor

ziirish commented Oct 16, 2018

Do you run the burp client with the appropriate permissions?

@jacky35
Copy link
Author

jacky35 commented Oct 16, 2018

it's Task Scheduler

@ziirish
Copy link
Contributor

ziirish commented Oct 16, 2018

If you open a cmd as admin then run burp.exe -a b (or -a t if you prefer) do you encounter the same behavior?

@jacky35
Copy link
Author

jacky35 commented Oct 16, 2018

I was wondering if there was not an influence if the server was in utf8 or not?

@ziirish
Copy link
Contributor

ziirish commented Oct 16, 2018

If you have include_glob = C:/Users/*/Documents, then the glob evaluation takes place client-side. So there is no encoding issue (that was the initial purpose of this option).

I don't have any Windows client anymore at hand so I can't give it a proper look, but if you have some time to troubleshoot your issue I'm available on IRC as usual.

@jacky35
Copy link
Author

jacky35 commented Oct 16, 2018

Tomorrow for IRC

server side log

WARNING: Could not stat C:/Users/RÃmi/AppData/Roaming/Mozilla: Unknown error
2018-10-16 18:46:43 +0200: burp[16252] WARNING: Could not stat C:/Users/RÃmi/AppData/Roaming/Thunderbird: Unknown error
2018-10-16 18:46:43 +0200: burp[16252] WARNING: Could not stat C:/Users/RÃmi/Desktop: Unknown error
2018-10-16 18:46:43 +0200: burp[16252] WARNING: Could not stat C:/Users/RÃmi/Documents: Unknown error


Client side log /

a/Roaming/Mozilla: Unknown error
2018-10-16 18:46:57: burp.exe[2700] WARNING: Could not stat C:/Users/RÚmi/AppDat
a/Roaming/Thunderbird: Unknown error
2018-10-16 18:46:57: burp.exe[2700] WARNING: Could not stat C:/Users/RÚmi/Deskto
p: Unknown error
2018-10-16 18:46:57: burp.exe[2700] WARNING: Could not stat C:/Users/RÚmi/Docume
nts: Unknown error

@jacky35
Copy link
Author

jacky35 commented Oct 18, 2018

I have everything I need to do tests.

Just tell me what you need as information.

@ziirish
Copy link
Contributor

ziirish commented Oct 18, 2018

Sorry, I had a busy day yesterday and haven't had a chance to have a look at your issue.

I'm available on IRC now if you like.

@jacky35
Copy link
Author

jacky35 commented Oct 18, 2018

After I can do a mklink but it's a little ugly. But it seems to work

mklink / d "C: \ Users \ Remi" "C: \ Users \ Rémi"

@ziirish
Copy link
Contributor

ziirish commented Oct 18, 2018

@grke I just troubleshooted the issue wirh @jacky35 and my guess is the glob evaluation is generating an include list that is not properly handled by Windows.

I don't have any Windows development environment anymore (neither the Windows client nor the .exe build tools) so it might take some time for me to give it a proper look.

In the meantime I proposed a workaround with the use of exclude_logic which seem to do the trick.

@grke
Copy link
Owner

grke commented Oct 19, 2018

OK, thanks for the effort and the workaround.
I am working on other high-priority burp things, so won't be able to look at it for a while either.

@imweijh
Copy link

imweijh commented Feb 16, 2019

@jacky35 encoding the burp.conf with utf-8.
Have a try.

@grke
Copy link
Owner

grke commented Feb 21, 2019

The windows glob stuff uses the windows functions FindFirstFileA and FindNextFileA.
I think it needs to use FindFirstFileW and FindNextFileW and convert the results to UTF-8.

Haven't had a chance to prove it yet, but I've got better at understanding this particular brand of windows madness recently, so I might come up with something soon-ish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants