This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

Document argument for unitTask/simpleTask #2

Open

grmble opened this issue Feb 13, 2018 · 1 comment

Labels

breaking change enhancement

Owner

grmble commented Feb 13, 2018

Right now, unitTask is basically useless - everything in core with no result but side effects needs a Document.

Giving these functions the Document from TaskContext would make them more useful.

grmble added enhancement breaking change labels

grmble mentioned this issue

Track subproject issues for 1.0 grmble/purescript-bonsai#37

Open

grmble added a commit that referenced this issue


          unitTest/simpleTest get the current document #2

6a1e9ae

grmble closed this as completed

Owner Author

grmble commented Jun 23, 2018 •

edited

Loading

In my experience using Bonsai so far, needing the document is the exception. In almost every case I used simpleTask, I've ignored the document arg.

simpleTask: no-arg, returns a single Cmd
unitTask: document argument, can not issue commands, for DOM side effects. Unchanged.
emittingTask: task context, can emit as often as it wants. Unchanged.

grmble reopened this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.