Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid matching on single quotes #3

Merged
merged 1 commit into from
May 18, 2015
Merged

Conversation

ultraflynn
Copy link
Contributor

The first group match in the regexp would match on a single quote and that resulted in results like this:

it's a nice day would become It'S A Nice Day

I have expanded the \w shortcut into the full version and added the single quote char: [^a-zA-Z0-9_']

I added a test to the README to cover this as well.

@grncdr grncdr merged commit 5b23f78 into grncdr:master May 18, 2015
@grncdr
Copy link
Owner

grncdr commented May 18, 2015

Thanks @ultraflynn: this is now released (along with international character support) in capitalize@1.0.0.

@ultraflynn
Copy link
Contributor Author

Marvellous. Thanks for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants