-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support port ranges #14
Comments
Current implementation in https://github.com/cejkato2/flowspy/tree/removeaddport uses From my opinion, there is no need to store ports separatly in DB because it makes no sense to select previously used values by user - it is much faster to write down the numbers than to look it up from some list. |
I understand your issues. However, there are some concerns about the whole
These are the major issues I see with this approach. Instead, I would propose that we:
As far as the user experience issues you mentioned, this is a different aspect I believe. Even with this As far as the API is concerned, we could do the same thing. That would be:
This will allow the user to do I am not that sure about the API though, I think maybe we could expose the models as they are there. Let me know what you think. |
The user should be able to specify a port range instead of single ports when adding rules. Any discussion / implementation details will be mentioned here.
The text was updated successfully, but these errors were encountered: