Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change names in kamaki code to comply with pep8 naming conventions #9

Closed
saxtouri opened this issue Apr 3, 2014 · 0 comments
Closed

Change names in kamaki code to comply with pep8 naming conventions #9

saxtouri opened this issue Apr 3, 2014 · 0 comments

Comments

@saxtouri
Copy link
Contributor

saxtouri commented Apr 3, 2014

Scan all kamaki code checking for pep8 naming conventions violations and modify accordingly.

In specific:

  • remove underscores from package names in kamaki.cli
  • shorten long package names in kamaki.cli
  • rename underscored classes into CamelCase in kamaki.cli.commands modules
  • add or remove leading underscores to internally or externally used classes in kamaki.cli.commands modules
  • rename classes to achieve uniformity in names where necessary, with respect to backwards compatibility
  • localize the use of global, underscore-prefixed variables in kamaki.cli modules. This required modification of some CLI methods which rely on the use of global variables. Remove variables that are rendered unnecessary after the changes.
  • rename CamelCase methods to underscored_methods in kamaki.cli.commands
  • rename leading underscore from methods used outside of the scope of the module of declaration in kamaki.cli modules
  • Push up in hierarchy commonly used member variables in kamaki.cli.command_tree and kamaki.cli.cyclades

Note: The package names kamaki.cli.commands and kamaki.cli.command_tree may be changed to kamaki.cli.cmds and kamaki.cli.cmd_tree respectively. Use this to make sense of the list above when some (but not all) renaming has been applied.
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 3, 2014
@saxtouri
Modify member methods in kamaki.cli.cmds classes
b7e866d 
Refs: grnet#9

Renamed:
kamaki.cli.cmds._optional_json: _print --> print_
kamaki.cli.cmds.cyclades.Wait: _wait --> wait
kamaki.cli.cmds.cyclades.ServerWait: _wait --> wait
kamaki.cli.cmds.image: _load_image_meta --> load_image_meta
kamak.cli.cmds.network: _wait --> wait
kamaki.cli.cmds.pithos.PithosAccount:
    _is_dir --> obj_is_dir
    _resolve_pithos_url --> resolve_pithos_url

Removed:
kamaki.cli.cmds.pithos.PithosAccount:
    _validate_image_meta, _validate_image_location
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 3, 2014
@saxtouri
Modify module methods in kamaki.cli classes
7a42aa0 
Refs: grnet#9

Renamed to comply with pep8:
kamaki.cli.config.Config: _cloud_name --> cloud_name
kamaki.cli.shell: _init_shell --> init_shell

Merged with caller methods because they where used only once:
kamaki.cli: _construct_command_syntax, _num_of_matching_terms
kamaki.cli.utils: _parse_with_regex
kamaki.cli.one_cmd: _get_cmd_tree_from_spec, _get_best_match_from_cmd_tree
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 4, 2014
@saxtouri
Rename base_url,auth_base to endpoint_url,astakos
43e7df6 
Refs: grnet#9

This change affects both the kamaki.cli and kamaki.clients hierarchies
It is of semantic significance only
Backwards compatibility is preserved in kamaki.clients, so that
old code using base_url instead of endpoint_url will still work.
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 9, 2014
@saxtouri
Modify member methods in kamaki.cli.cmds classes
51ef8a1 
Refs: grnet#9

Renamed:
kamaki.cli.cmds._optional_json: _print --> print_
kamaki.cli.cmds.cyclades.Wait: _wait --> wait
kamaki.cli.cmds.cyclades.ServerWait: _wait --> wait
kamaki.cli.cmds.image: _load_image_meta --> load_image_meta
kamak.cli.cmds.network: _wait --> wait
kamaki.cli.cmds.pithos.PithosAccount:
    _is_dir --> obj_is_dir
    _resolve_pithos_url --> resolve_pithos_url

Removed:
kamaki.cli.cmds.pithos.PithosAccount:
    _validate_image_meta, _validate_image_location
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 9, 2014
@saxtouri
Modify module methods in kamaki.cli classes
a1c5ea9 
Refs: grnet#9

Renamed to comply with pep8:
kamaki.cli.config.Config: _cloud_name --> cloud_name
kamaki.cli.shell: _init_shell --> init_shell

Merged with caller methods because they where used only once:
kamaki.cli: _construct_command_syntax, _num_of_matching_terms
kamaki.cli.utils: _parse_with_regex
kamaki.cli.one_cmd: _get_cmd_tree_from_spec, _get_best_match_from_cmd_tree
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 9, 2014
@saxtouri
Rename base_url,auth_base to endpoint_url,astakos
5344af0 
Refs: grnet#9

This change affects both the kamaki.cli and kamaki.clients hierarchies
It is of semantic significance only
Backwards compatibility is preserved in kamaki.clients, so that
old code using base_url instead of endpoint_url will still work.
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 24, 2014
@saxtouri
Remove "PERMANENTS" from kamaki.cli.cmds classes
214df60 
Resolves: grnet#9

This variable was used only once per case
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 24, 2014
@saxtouri
Modify module methods in kamaki.cli classes
07b6e81 
Refs: grnet#9

Renamed to comply with pep8:
kamaki.cli.config.Config: _cloud_name --> cloud_name
kamaki.cli.shell: _init_shell --> init_shell

Merged with caller methods because they where used only once:
kamaki.cli: _construct_command_syntax, _num_of_matching_terms
kamaki.cli.utils: _parse_with_regex
kamaki.cli.one_cmd: _get_cmd_tree_from_spec, _get_best_match_from_cmd_tree

Remove now unused method _num_of_matching_terms
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 24, 2014
@saxtouri
Rename base_url,auth_base to endpoint_url,astakos
5d7727a 
Refs: grnet#9

This change affects both the kamaki.cli and kamaki.clients hierarchies
It is of semantic significance only
Backwards compatibility is preserved in kamaki.clients, so that
old code using base_url instead of endpoint_url will still work.
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 24, 2014
@saxtouri
Remove "PERMANENTS" from kamaki.cli.cmds classes
2224983 
Resolves: grnet#9

This variable was used only once per case
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 24, 2014
@saxtouri
Rename base_url,auth_base to endpoint_url,astakos
26b7339 
Refs: grnet#9

This change affects both the kamaki.cli and kamaki.clients hierarchies
It is of semantic significance only
Backwards compatibility is preserved in kamaki.clients, so that
old code using base_url instead of endpoint_url will still work.
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 24, 2014
@saxtouri
Remove "PERMANENTS" from kamaki.cli.cmds classes
9327948 
Resolves: grnet#9

This variable was used only once per case
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 29, 2014
@saxtouri
Modify member methods in kamaki.cli.cmds classes
6f61f9c 
Refs: grnet#9

Renamed:
kamaki.cli.cmds._optional_json: _print --> print_
kamaki.cli.cmds.cyclades.Wait: _wait --> wait
kamaki.cli.cmds.cyclades.ServerWait: _wait --> wait
kamaki.cli.cmds.image: _load_image_meta --> load_image_meta
kamak.cli.cmds.network: _wait --> wait
kamaki.cli.cmds.pithos.PithosAccount:
    _is_dir --> obj_is_dir
    _resolve_pithos_url --> resolve_pithos_url

Removed:
kamaki.cli.cmds.pithos.PithosAccount:
    _validate_image_meta, _validate_image_location
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 29, 2014
@saxtouri
Modify module methods in kamaki.cli classes
8e29af5 
Refs: grnet#9

Renamed to comply with pep8:
kamaki.cli.config.Config: _cloud_name --> cloud_name
kamaki.cli.shell: _init_shell --> init_shell

Merged with caller methods because they where used only once:
kamaki.cli: _construct_command_syntax, _num_of_matching_terms
kamaki.cli.utils: _parse_with_regex
kamaki.cli.one_cmd: _get_cmd_tree_from_spec, _get_best_match_from_cmd_tree

Remove now unused method _num_of_matching_terms
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 29, 2014
@saxtouri
Rename base_url,auth_base to endpoint_url,astakos
21da73f 
Refs: grnet#9

This change affects both the kamaki.cli and kamaki.clients hierarchies
It is of semantic significance only
Backwards compatibility is preserved in kamaki.clients, so that
old code using base_url instead of endpoint_url will still work.
saxtouri added a commit to saxtouri/kamaki that referenced this issue Apr 29, 2014
@saxtouri
Remove "PERMANENTS" from kamaki.cli.cmds classes
2e1b63d 
Resolves: grnet#9

This variable was used only once per case
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 7, 2014
@saxtouri
Modify member methods in kamaki.cli.cmds classes
81484c2 
Refs: grnet#9

Renamed:
kamaki.cli.cmds._optional_json: _print --> print_
kamaki.cli.cmds.cyclades.Wait: _wait --> wait
kamaki.cli.cmds.cyclades.ServerWait: _wait --> wait
kamaki.cli.cmds.image: _load_image_meta --> load_image_meta
kamak.cli.cmds.network: _wait --> wait
kamaki.cli.cmds.pithos.PithosAccount:
    _is_dir --> obj_is_dir
    _resolve_pithos_url --> resolve_pithos_url

Removed:
kamaki.cli.cmds.pithos.PithosAccount:
    _validate_image_meta, _validate_image_location
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 7, 2014
@saxtouri
Modify module methods in kamaki.cli classes
f28edac 
Refs: grnet#9

Renamed to comply with pep8:
kamaki.cli.config.Config: _cloud_name --> cloud_name
kamaki.cli.shell: _init_shell --> init_shell

Merged with caller methods because they where used only once:
kamaki.cli: _construct_command_syntax, _num_of_matching_terms
kamaki.cli.utils: _parse_with_regex
kamaki.cli.one_cmd: _get_cmd_tree_from_spec, _get_best_match_from_cmd_tree

Remove now unused method _num_of_matching_terms
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 7, 2014
@saxtouri
Rename base_url,auth_base to endpoint_url,astakos
cf239e1 
Refs: grnet#9

This change affects both the kamaki.cli and kamaki.clients hierarchies
It is of semantic significance only
Backwards compatibility is preserved in kamaki.clients, so that
old code using base_url instead of endpoint_url will still work.
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 7, 2014
@saxtouri
Remove "PERMANENTS" from kamaki.cli.cmds classes
44b56ec 
Resolves: grnet#9

This variable was used only once per case
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 12, 2014
@saxtouri
Modify member methods in kamaki.cli.cmds classes
89ea691 
Refs: grnet#9

Renamed:
kamaki.cli.cmds._optional_json: _print --> print_
kamaki.cli.cmds.cyclades.Wait: _wait --> wait
kamaki.cli.cmds.cyclades.ServerWait: _wait --> wait
kamaki.cli.cmds.image: _load_image_meta --> load_image_meta
kamak.cli.cmds.network: _wait --> wait
kamaki.cli.cmds.pithos.PithosAccount:
    _is_dir --> obj_is_dir
    _resolve_pithos_url --> resolve_pithos_url

Removed:
kamaki.cli.cmds.pithos.PithosAccount:
    _validate_image_meta, _validate_image_location
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 12, 2014
@saxtouri
Modify module methods in kamaki.cli classes
e6fbc2c 
Refs: grnet#9

Renamed to comply with pep8:
kamaki.cli.config.Config: _cloud_name --> cloud_name
kamaki.cli.shell: _init_shell --> init_shell

Merged with caller methods because they where used only once:
kamaki.cli: _construct_command_syntax, _num_of_matching_terms
kamaki.cli.utils: _parse_with_regex
kamaki.cli.one_cmd: _get_cmd_tree_from_spec, _get_best_match_from_cmd_tree

Remove now unused method _num_of_matching_terms
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 12, 2014
@saxtouri
Rename base_url,auth_base to endpoint_url,astakos
a7fd814 
Refs: grnet#9

This change affects both the kamaki.cli and kamaki.clients hierarchies
It is of semantic significance only
Backwards compatibility is preserved in kamaki.clients, so that
old code using base_url instead of endpoint_url will still work.
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 12, 2014
@saxtouri
Remove "PERMANENTS" from kamaki.cli.cmds classes
2956f08 
Resolves: grnet#9

This variable was used only once per case
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 12, 2014
@saxtouri
Modify member methods in kamaki.cli.cmds classes
f3af64f 
Refs: grnet#9

Renamed:
kamaki.cli.cmds._optional_json: _print --> print_
kamaki.cli.cmds.cyclades.Wait: _wait --> wait
kamaki.cli.cmds.cyclades.ServerWait: _wait --> wait
kamaki.cli.cmds.image: _load_image_meta --> load_image_meta
kamak.cli.cmds.network: _wait --> wait
kamaki.cli.cmds.pithos.PithosAccount:
    _is_dir --> obj_is_dir
    _resolve_pithos_url --> resolve_pithos_url

Removed:
kamaki.cli.cmds.pithos.PithosAccount:
    _validate_image_meta, _validate_image_location
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 12, 2014
@saxtouri
Modify module methods in kamaki.cli classes
ed7c6ed 
Refs: grnet#9

Renamed to comply with pep8:
kamaki.cli.config.Config: _cloud_name --> cloud_name
kamaki.cli.shell: _init_shell --> init_shell

Merged with caller methods because they where used only once:
kamaki.cli: _construct_command_syntax, _num_of_matching_terms
kamaki.cli.utils: _parse_with_regex
kamaki.cli.one_cmd: _get_cmd_tree_from_spec, _get_best_match_from_cmd_tree

Remove now unused method _num_of_matching_terms
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 12, 2014
@saxtouri
Rename base_url,auth_base to endpoint_url,astakos
cf680e9 
Refs: grnet#9

This change affects both the kamaki.cli and kamaki.clients hierarchies
It is of semantic significance only
Backwards compatibility is preserved in kamaki.clients, so that
old code using base_url instead of endpoint_url will still work.
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 12, 2014
@saxtouri
Remove "PERMANENTS" from kamaki.cli.cmds classes
039d3fc 
Resolves: grnet#9

This variable was used only once per case
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 21, 2014
@saxtouri
Modify member methods in kamaki.cli.cmds classes
04157ec 
Refs: grnet#9

Renamed:
kamaki.cli.cmds._optional_json: _print --> print_
kamaki.cli.cmds.cyclades.Wait: _wait --> wait
kamaki.cli.cmds.cyclades.ServerWait: _wait --> wait
kamaki.cli.cmds.image: _load_image_meta --> load_image_meta
kamak.cli.cmds.network: _wait --> wait
kamaki.cli.cmds.pithos.PithosAccount:
    _is_dir --> obj_is_dir
    _resolve_pithos_url --> resolve_pithos_url

Removed:
kamaki.cli.cmds.pithos.PithosAccount:
    _validate_image_meta, _validate_image_location
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 21, 2014
@saxtouri
Modify module methods in kamaki.cli classes
1d3db4d 
Refs: grnet#9

Renamed to comply with pep8:
kamaki.cli.config.Config: _cloud_name --> cloud_name
kamaki.cli.shell: _init_shell --> init_shell

Merged with caller methods because they where used only once:
kamaki.cli: _construct_command_syntax, _num_of_matching_terms
kamaki.cli.utils: _parse_with_regex
kamaki.cli.one_cmd: _get_cmd_tree_from_spec, _get_best_match_from_cmd_tree

Remove now unused method _num_of_matching_terms
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 21, 2014
@saxtouri
Rename base_url,auth_base to endpoint_url,astakos
c417dc5 
Refs: grnet#9

This change affects both the kamaki.cli and kamaki.clients hierarchies
It is of semantic significance only
Backwards compatibility is preserved in kamaki.clients, so that
old code using base_url instead of endpoint_url will still work.
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 21, 2014
@saxtouri
Remove "PERMANENTS" from kamaki.cli.cmds classes
aaf5a8c 
Resolves: grnet#9

This variable was used only once per case
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 21, 2014
@saxtouri
Modify member methods in kamaki.cli.cmds classes
a5acf92 
Refs grnet#9

Renamed:
kamaki.cli.cmds._optional_json: _print --> print_
kamaki.cli.cmds.cyclades.Wait: _wait --> wait
kamaki.cli.cmds.cyclades.ServerWait: _wait --> wait
kamaki.cli.cmds.image: _load_image_meta --> load_image_meta
kamak.cli.cmds.network: _wait --> wait
kamaki.cli.cmds.pithos.PithosAccount:
    _is_dir --> obj_is_dir
    _resolve_pithos_url --> resolve_pithos_url

Removed:
kamaki.cli.cmds.pithos.PithosAccount:
    _validate_image_meta, _validate_image_location
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 21, 2014
@saxtouri
Modify module methods in kamaki.cli classes
9765967 
Refs grnet#9

Renamed to comply with pep8:
kamaki.cli.config.Config: _cloud_name --> cloud_name
kamaki.cli.shell: _init_shell --> init_shell

Merged with caller methods because they where used only once:
kamaki.cli: _construct_command_syntax, _num_of_matching_terms
kamaki.cli.utils: _parse_with_regex
kamaki.cli.one_cmd: _get_cmd_tree_from_spec, _get_best_match_from_cmd_tree

Remove now unused method _num_of_matching_terms
saxtouri added a commit to saxtouri/kamaki that referenced this issue May 21, 2014
@saxtouri
Rename base_url,auth_base to endpoint_url,astakos
998d7e2 
Refs grnet#9

This change affects both the kamaki.cli and kamaki.clients hierarchies
It is of semantic significance only
Backwards compatibility is preserved in kamaki.clients, so that
old code using base_url instead of endpoint_url will still work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saxtouri