Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal metrics sent via 'statistics send to cluster' counted as blackholed as well as sent. #405

Closed
lexx-bright opened this issue Feb 7, 2020 · 3 comments
Closed

Internal metrics sent via 'statistics send to cluster' counted as blackholed as well as sent. #405

lexx-bright opened this issue Feb 7, 2020 · 3 comments

Comments

@lexx-bright
Copy link
Contributor 

cluster test  forward 127.0.0.1:10000 ;
statistics send to test stop ;
match * send to test ;

# nc -k -l 127.0.0.1 10000 | egrep 'novalocal.metrics(Received|Blackholed|Sent)'  
carbon.relays.carbon36test_novalocal.metricsReceived 0 1581062199
carbon.relays.carbon36test_novalocal.metricsBlackholed 0 1581062199
carbon.relays.carbon36test_novalocal.metricsSent 0 1581062199
carbon.relays.carbon36test_novalocal.metricsReceived 42 1581062259
carbon.relays.carbon36test_novalocal.metricsBlackholed 42 1581062259
carbon.relays.carbon36test_novalocal.metricsSent 42 1581062259
@grobian
Copy link
Owner

grobian commented Feb 13, 2020

hmmm, yeah, this looks odd.

grobian added a commit that referenced this issue Feb 13, 2020
@grobian
router: don't count stubbed metrics as blackholed, #405
8f05608 
Fix Issue #405.  Metrics that are stubbed, are recursively re-routed,
and the recursion did not take into account that while the inner
succeeds, it didn't itself send the metric anywhere.
@grobian
Copy link
Owner

grobian commented Feb 13, 2020

I think this will do. (For me it did the trick.)

@lexx-bright
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grobian @lexx-bright