Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move file then add over moved source does not perform correct move update #194

Open
groboclown opened this issue Jan 18, 2019 · 0 comments
Labels
bug good first issue For those looking to work on the plugin
Projects

Comments

@groboclown
Copy link
Owner

Describe the bug
Moving a file then adding a new file over the source of the move operation does not perform the correct move correction to the pending changelist.

To Reproduce
Steps to reproduce the behavior:

  1. Move a file which is known by Perforce, say "a.txt" to "b.txt"
  2. Add a new file to the source ("a.txt" in step 1).

As of 0.10.2, this only attempted to add the new file to the changelist, which caused an unreported Perforce warning. In 0.10.3, this attempts to revert the "a.txt", which fails, then adds in "a.txt", which is the same issue.

Expected behavior
The OpenFileStatus class needs to correctly report on the status for moved files, because these should be reverted together. Additionally, all consumers of the OpenFileStatus class need to include specialized logic for handling the moved files.

@groboclown groboclown added the bug label Jan 18, 2019
@groboclown groboclown added this to Planning in v3 via automation Jan 18, 2019
groboclown added a commit that referenced this issue Jan 18, 2019
…is around, and if things are cleaning up correctly. Added fixes for #181.  Added an initial bit of code to help with #194, but it still is not fixed.
groboclown added a commit that referenced this issue Jan 18, 2019
…is around, and if things are cleaning up correctly. Added fixes for #181.  Added an initial bit of code to help with #194, but it still is not fixed.
@groboclown groboclown added the good first issue For those looking to work on the plugin label Jan 18, 2019
@groboclown groboclown changed the title Move file then add over moved source does not perform correct move correction Move file then add over moved source does not perform correct move update Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue For those looking to work on the plugin
Projects
v3
  
Planning
Development

No branches or pull requests

1 participant