Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date picker 1.13.1 #14

Closed
BlizzWave opened this issue Jul 13, 2018 · 9 comments
Closed

Date picker 1.13.1 #14

BlizzWave opened this issue Jul 13, 2018 · 9 comments
Labels

Comments

@BlizzWave
Copy link
Contributor

There is an issue with the date picker in 1.13.1
In the "Inventory" and "Purchase" the date picker is not working. The Icon is also not aligned correctly.

@berrnd
Copy link
Member

berrnd commented Jul 13, 2018

I also noticed that the border around the picker is a little too small - I think this has to do with showing calendar weeks and is a problem in the upstream CSS - will try to improve it...

The rest looks and works ok, or not?

Just tried in the current demo:

2018-07-13_21-23-32

@berrnd
Copy link
Member

berrnd commented Jul 13, 2018

The border problem is fixed, now looks like this:

2018-07-13_21-38-55

@BlizzWave
Copy link
Contributor Author

BlizzWave commented Jul 13, 2018

Seems like there still is an issue. Atleast for me.
I am working on translating to Norwegian. So I thought maybe I messed up something.
Tried switching back to english, but still the same.

untitled

@berrnd
Copy link
Member

berrnd commented Jul 14, 2018

I had that same effect while upgrading all the dependencies some days ago, especially Bootstrap - have you replaced all files?

Maybe you can check in the browser developer console if there is something not loaded, all the frontend dependencies are in folder public/node_modules.

berrnd added a commit that referenced this issue Jul 14, 2018
… this does not work for side-by-side with time picker (references #14)
@BlizzWave
Copy link
Contributor Author

Deleted everything (instead of overwriting).
Looks better, but not perfect.

Also is there a way of setting start of the week as monday and not sunday?

datop

@berrnd
Copy link
Member

berrnd commented Jul 14, 2018

Ok, then this was the problem - the width problem is fixed in the next release as mentioned above, or grab and replace grocy.css from master branch manually if you want to test it now.

The localization of the calendar comes from Moment.js, for German the first day of the week is also monday - you have to set this translation item to a available Moment.js localization file name (should be just nl I think...).

@BlizzWave
Copy link
Contributor Author

Had to update datetimepicker.blade.php with the one from your source.

Had to add "'additionalCssClasses' => 'date-only-datetimepicker'"
to purchase.blade.php and inventory.blade.php also.

Adding "nb" to the translation file it showes the correct format in the calendar.
I was using "no", haha.

But this will be fixed in your next release. So consider this "bug" fixed.

@berrnd
Copy link
Member

berrnd commented Jul 15, 2018

Would be cool if could share (create a pull request) your translation. (?) :)

There will be a new release later today with all the small UI improvements and one big new feature - Recipes (auto check if everything is in stock for a recipe, put the missing things on the shopping list, and so on)...

@BlizzWave
Copy link
Contributor Author

Sure I can do that. Just need to figure out the correct way of translating everything. I have been going back and forth about how something should be translated without it sounding stupid.

Thought you said you did not have time to work on grocy that much?!?
Haha.

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants