Some bug fixes. #1000
Merged
Some bug fixes. #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E_DATE is not set.
…checkbox" (e.g. "never expires") was checked.
berrnd
added a commit
that referenced
this pull request
Sep 14, 2020
berrnd
added a commit
that referenced
this pull request
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
515da5d The datetimepicker is now removed if FEATURE_FLAG_STOCK_BEST_BEFORE_DATE_TRACKING is not set (fixes FEATURE_FLAG_STOCK_BEST_BEFORE_DATE_TRACKING not removing element from form #997)
9f9acb7
DateTimePicker.SetValue()did not set the value if the shortcut-checkbox was checked (e.g. "Never expires") - it only cleared the field and the checkbox (caused FEATURE_FLAG_STOCK_BEST_BEFORE_DATE_TRACKING not removing element from form #997: without FEATURE_FLAG_STOCK_BEST_BEFORE_DATE_TRACKING, the field is set to "Never Expires". When you choose a product with default-best-before-date, the field is cleared/empty and hidden, and the validation failed.)ef2e5dd Clicking the whole (highlighted) area in drop downs with checkboxes now toggles the checkbox.
50ee248 Night-mode enabling does not need a reload
Some undefined variables