Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes are required to validate datetime type #60

Closed
jdandrea opened this issue Jun 3, 2016 · 6 comments
Closed

Quotes are required to validate datetime type #60

jdandrea opened this issue Jun 3, 2016 · 6 comments

Comments

@jdandrea
Copy link

jdandrea commented Jun 3, 2016

Given the schema:

type: map
mapping:
  d1:
    type: timestamp

and data:

d1: 2015-03-29

The following error is returned:

Value '2015-03-29' is not of type 'timestamp'. Path: '/d1', Not a valid timestamp

However, enclosing the date in quotes works:

d1: "2015-03-29"

Expectation: Quotes should not be required for the value to be recognized as a valid datetime type.

@jdandrea
Copy link
Author

jdandrea commented Jun 3, 2016

(Also suddenly getting a feeling of deja vu. I think I filed something similar to this a while ago. Hopefully not the same thing! Maybe related.)

@Grokzen
Copy link
Owner

Grokzen commented Jun 3, 2016

What version are you running this on? the latest released? It should be rather easy to track down.

@Grokzen
Copy link
Owner

Grokzen commented Jun 4, 2016

@jdandrea I think i found the reason for this. If you look here 1.5.1...unstable#diff-80ba2584958bd7cca1bb82dd943c87cfR241 (The diff between last release and HEAD you see that there is tests in there to validate just this case and i think there is a fix in there somewhere to sort out your timestamp problem. I will go through the current changes and see if i can get a new minor release out today or tomorrow and hopefully your problem should be fixed.

If you want to validate it before that happens, you can test your schema against the latest commit in unstable branch.

@jdandrea
Copy link
Author

jdandrea commented Jun 6, 2016

Thank you in advance! Yes, I'm on 1.5.1.

@Grokzen
Copy link
Owner

Grokzen commented Nov 5, 2016

@jdandrea Release will be out later today. Closing this for now.

@Grokzen Grokzen closed this as completed Nov 5, 2016
@jdandrea
Copy link
Author

jdandrea commented Nov 7, 2016

Thank you! Appreciate the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants