Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Improve documentation for Tab #272

Closed
alansouzati opened this issue Jun 13, 2017 · 2 comments
Closed

Improve documentation for Tab #272

alansouzati opened this issue Jun 13, 2017 · 2 comments
Assignees

Comments

@alansouzati
Copy link
Collaborator

Tabs doc does not describe the properties for the Tab component.

@cherih cherih self-assigned this Jul 6, 2017
cherih added a commit to cherih/grommet-docs that referenced this issue Jul 11, 2017
…nor fix to preamble on the Hero examples page.
@cherih
Copy link
Contributor

cherih commented Jul 11, 2017

Added a Tab Properties section to the Tabs doc page. The only property described in this new section is the title property. All other Tab properties are used by the Tabs component and should not be specified by the user.

This is patterned after the List doc page, which shows both List and ListItem properties.

alansouzati pushed a commit that referenced this issue Jul 11, 2017
* Fixes #1395 - some FormField props aren't documented.

* Fix lint errors for #1395 - some FormField props aren't documented.

* Fix for #272 - improve documentation for Tab. Also included minor fix to preamble on the Hero examples page.
@cherih
Copy link
Contributor

cherih commented Jul 12, 2017

This issue was fixed by PR #280.

@cherih cherih closed this as completed Jul 12, 2017
@ghost ghost removed the in progress label Jul 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants