Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Card docs #324

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+252 −239
Open

Update Card docs #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b36ac97
Update Card docs
taysea Nov 3, 2021
914c53c
Merge branch 'master' into card-hover-elevation
taysea Apr 15, 2022
185f3d2
Merge branch 'master' into card-hover-elevation
taysea Jun 27, 2022
6cc28cb
Update yarn.lock
taysea Jun 27, 2022
5521522
Update yarn.lock
taysea Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/screens/Card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,13 @@ const CardPage = () => (
</PropertyValue>
</Property>

<Property name="card.container.extend">
<Description>
Any additional style for the card container.
</Description>
<GenericExtend />
</Property>

<Property name="card.footer">
<Description>Any valid Box prop for the CardFooter.</Description>
<PropertyValue type="object">
Expand All @@ -86,13 +93,6 @@ const CardPage = () => (
<Example>"small"</Example>
</PropertyValue>
</Property>

<Property name="card.hover.container.extend">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this still possible, via

kind={{
    hover: theme.card.hover?.container,
    ...theme.card.container,
}}

Copy link
Collaborator Author

@taysea taysea Apr 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extend does not apply at the moment.

<Description>
Any additional style for the card container.
</Description>
<GenericExtend />
</Property>
</ThemeDoc>
</ComponentDoc>

Expand Down
Loading