Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggleGroup #517

Merged
merged 17 commits into from
Apr 25, 2024
Merged

toggleGroup #517

merged 17 commits into from
Apr 25, 2024

Conversation

britt6612
Copy link
Collaborator

Start ToggleGroup docs

@britt6612 britt6612 marked this pull request as draft April 18, 2024 20:24
@britt6612
Copy link
Collaborator Author

britt6612 commented Apr 18, 2024

  • need to add default values for theme

@britt6612 britt6612 changed the title draft toggleGroup--no-verify draft toggleGroup Apr 18, 2024
@britt6612 britt6612 marked this pull request as ready for review April 22, 2024 19:29
@britt6612 britt6612 requested a review from taysea April 22, 2024 19:32
@britt6612 britt6612 changed the title draft toggleGroup toggleGroup Apr 22, 2024
src/screens/ToggleGroup.js Outdated Show resolved Hide resolved
<Properties>
<Property name="multiple">
<Description>
This will allow more than one of the buttons within ToggleGroup to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording suggestion to mirror what we have in Select:

Whether to allow multiple options to be selected. When multiple is true, 'value' should be an array of selected options.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/screens/ToggleGroup.js Outdated Show resolved Hide resolved
src/screens/ToggleGroup.js Outdated Show resolved Hide resolved
src/screens/ToggleGroup.js Outdated Show resolved Hide resolved
src/screens/ToggleGroup.js Outdated Show resolved Hide resolved
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
src/screens/ToggleGroup.js Outdated Show resolved Hide resolved
britt6612 and others added 5 commits April 22, 2024 20:25
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
@britt6612 britt6612 requested a review from taysea April 23, 2024 17:21
src/screens/ToggleGroup.js Outdated Show resolved Hide resolved
src/screens/ToggleGroup.js Outdated Show resolved Hide resolved
britt6612 and others added 2 commits April 23, 2024 12:31
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
@britt6612 britt6612 requested a review from taysea April 23, 2024 21:14
src/screens/ToggleGroup.js Outdated Show resolved Hide resolved
src/screens/ToggleGroup.js Outdated Show resolved Hide resolved
@taysea taysea merged commit 8b0f205 into grommet:master Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants