Styled components 6 support #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
&in front of pseudoselectors. In styled components 5 this was implicitly included if it wasn't already there but in styled components 6 this needs to be manually added.https://styled-components.com/docs/faqs#nested-syntax-handling
What testing has been done on this PR?
Tested locally on DS site with this PR grommet/hpe-design-system#3880
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
before:
after:
before:
after:
Is this change backward compatible or could it be a breaking change for the official HPE theme?
backwards compatible
How should this PR be communicated in the release notes?
styled components v6 support