Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI - validate publication by verifying new release in an app #2978

Closed
ShimiSun opened this issue Mar 25, 2019 · 4 comments
Closed

CircleCI - validate publication by verifying new release in an app #2978

ShimiSun opened this issue Mar 25, 2019 · 4 comments
Assignees
Labels
enhancement A suggestion to add to or change behavior

Comments

@ShimiSun
Copy link
Member

Expected Behavior

currently CircleCI is publishing the release but not testing whether it is working.

Actual Behavior

URL, screen shot, or Codepen exhibiting the issue

Steps to Reproduce

Your Environment

any

  • Grommet version: 2.6.5
  • Browser Name and version: any
  • Operating System and version (desktop or mobile): any
@oorestisime
Copy link
Collaborator

How should the release be tested?

@ShimiSun ShimiSun added the enhancement A suggestion to add to or change behavior label Mar 25, 2019
@ShimiSun ShimiSun self-assigned this Mar 27, 2019
@ShimiSun
Copy link
Member Author

@oorestisime working on a PR now, I was thinking a simple yarn build on a cloned repo with the newly released version should be enough. what did you have in mind?

@oorestisime
Copy link
Collaborator

Well i hope once we get monorepo we build all the patterns in every PR or every master push to netlify. but yes probably linking the release in a cloned repo could be enough now.

@ShimiSun
Copy link
Member Author

@oorestisime agree. eric had a nice idea that I've implemented and it didn't require cloning. let me know what you think on the PR ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggestion to add to or change behavior
Projects
None yet
Development

No branches or pull requests

2 participants