-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS] Improve event handler typings for all components #3165
Comments
Personally, not having types for the values from My solution would be to make onSubmit?: ((event: {value: V}) => void); |
Listing all of the components in which we need to improve event handler typing'sAccordionProps
AnchorProps
Button
Calendar
ChartProps
CheckBoxProps
ClockProps
DataTableProps
DistributionProps
DropProps
DropButtonProps
FormProps
InfiniteScrollProps
KeyBoardProps
MarginType
MaskedInputProps
RadioButtonProps
RadioButtonGroupProps
RangeInputProps
RangeSelectorProps
SelectProps
TabsProps
TextAreaProps
TextInputProps
WorldMapProps
|
@jcfilben Can we update/edit the requirements list and prep it for Hacktoberfest? |
2020 Updated Listall of the components in which we need to improve event handler typing's Anchor
Box
Button
Calendar
Chart
CheckBox
Distribution
Drop
DropButton
InfiniteScroll
Layer
List
MaskedInput
Meter
RadioButton
RangeInput
RangeSelector
Select
TextArea
WorldMap
|
2021 Updated Listall of the components in which we need to improve event handler typing's Anchor
Box
Button
Chart
CheckBox
Distribution
InfiniteScroll
MaskedInput
RadioButton
RangeInput
RangeSelector
Select
TextArea
|
Is this issue being actively pursued? |
This is an issue we would still like to get finished up and would love help from the community on this |
Currently most (if not all) components' event handlers have the following typing:
((...args: any[]) => any);
. This should be fixed and modified to the appropriate handler typing for each event.TODO: List all components concerned and fix progressively.
The text was updated successfully, but these errors were encountered: