Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select dropdown options become empty while in a scrollable modal due to InfiniteScroll #3636

Closed
aga5tya opened this issue Dec 30, 2019 · 2 comments
Labels
in progress Currently in development

Comments

@aga5tya
Copy link

aga5tya commented Dec 30, 2019

Expected Behavior

Select dropdown with search enabled becomes empty when its placed in a Layer that has scroll in it and body has scroll enabled.

Actual Behavior

Select dropdown with search enabled and placed inside a modal with fewer options that results in no scroll, InfiniteScroll.js seems to compute nextBeginPage & nextEndPage to be same (1 in my case) which results in array slicing to be off and becomes empty array.

  • Grommet version: v2.9.0
  • Browser Name and version: Chrome latest
@aga5tya aga5tya changed the title Select dropdown options goes invisible while in a scrollable modal Select dropdown options become empty while in a scrollable modal due to InfiniteScroll Dec 30, 2019
@ShimiSun ShimiSun added the in progress Currently in development label Dec 30, 2019
@IanKBovard
Copy link
Contributor

@aga5tya Could you give me an example I can toy around with. Just want to make sure I understand what this issue is.

@ShimiSun
Copy link
Collaborator

ShimiSun commented Jul 7, 2020

We no longer seem to be able to reproduce this issue, feel free to reopen and file an issue that we can reproduce & investigate, thank you all for your cooperation.

@ShimiSun ShimiSun closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Currently in development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants