Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook Accessibility Violations #6124

Open
31 of 68 tasks
jcfilben opened this issue May 11, 2022 · 2 comments
Open
31 of 68 tasks

Storybook Accessibility Violations #6124

jcfilben opened this issue May 11, 2022 · 2 comments
Labels
accessibility WCAG support good first issue A good one to work on if you are just getting started with grommet hacktoberfest PRs submitted in October (open-source celebration month) help wanted Would appreciate community help working on this

Comments

@jcfilben
Copy link
Collaborator

jcfilben commented May 11, 2022 •
edited

Recently the addon-a11y tool was added to storybook which has flagged a number of accessibility violations. To see the violations go to storybook and below each story click the accessibility tab. It would be great to clean up these accessibility violations. Some fixes may just require changes to story while others will require changes to grommet components. Below is a list of stories with accessibility violations. Feel free to contribute fixes per story or per component.

  • All

Accordion

Drop

Menu

Pagination

  • (component wide error) <ul> and <ol> must only directly contain <li>, <script> or <template> elements
  • Number edge pages
  • Number middle pages
  • Simple
  • Size

CheckBox

FileInput

Form

FormField

  • Simple

MaskedInput

RangeInput

Select

  • (component wide error) Interactive controls must not be nested

TextArea

TextInput

Box

Card

  • Simple

Footer

  • Double footer
  • Sitemap
  • Social

Header

Layer

  • Target

Sidebar

Carousel

Markdown

Paragraph

  • All

AnnounceContext

Grommet

InfiniteScroll

SkipLinks

Theme

  • Colors

ThemeContext

  • Extend

Chart

DataTable

Distribution

List

  • Selection
  • Order
  • onClickItem
  • Key Render
  • Paginated

Notification
@jcfilben jcfilben added accessibility WCAG support help wanted Would appreciate community help working on this labels May 11, 2022
@jcfilben jcfilben added the hacktoberfest PRs submitted in October (open-source celebration month) label Sep 21, 2022
This was referenced Oct 1, 2022
Merged
Merged
@julieg18
Copy link
Contributor

julieg18 commented Oct 1, 2022 •
edited

Hello, I'd love to help improve the accessibility for the storybooks! May I be assigned to this issue?

@uldz uldz mentioned this issue Oct 1, 2022
Merged
4 tasks
@jcfilben
Copy link
Collaborator Author

jcfilben commented Oct 2, 2022 •
edited

Hello, I'd love to help improve the accessibility for the storybooks! May I be assigned to this issue?

Hi @julieg18 great to hear you are interested in working on this! I think since this is a larger issue items on the list can be handled either by component or one by one through separate pull requests. There may be many contributors to this issue so I am going to hold off assigning any one person to this, but feel free to start filing pull requests against this issue. Let me know if there are any questions!

This was referenced Oct 3, 2022
Merged
Merged
Merged
@miqh miqh mentioned this issue Oct 11, 2022
Merged
4 tasks
ericsoderberghp added a commit that referenced this issue Oct 12, 2022
@miqh @ericsoderberghp
Fix Storybook a11y violation for carousel (#6124) (#6414)
ff82288 
Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com>
@miqh miqh mentioned this issue Oct 12, 2022
Merged
4 tasks
@KostasTheodoro KostasTheodoro mentioned this issue Oct 13, 2022
Merged
4 tasks
ericsoderberghp added a commit that referenced this issue Oct 13, 2022
@miqh @ericsoderberghp
Fix Storybook a11y violations for file input (#6124) (#6417)
aad44bf 
Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com>
@KostasTheodoro KostasTheodoro mentioned this issue Oct 13, 2022
Merged
4 tasks
This was referenced Oct 14, 2022
Merged
Merged
@KostasTheodoro KostasTheodoro mentioned this issue Oct 14, 2022
Merged
4 tasks
@julieg18 julieg18 mentioned this issue Oct 16, 2022
Merged
4 tasks
ericsoderberghp added a commit that referenced this issue Oct 17, 2022
@miqh @ericsoderberghp
Fix Storybook a11y violations for chart (#6124) (#6422)
6b73d5e 
Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com>
ericsoderberghp added a commit that referenced this issue Oct 17, 2022
@miqh @ericsoderberghp
Fix Storybook a11y violations for range input (#6124) (#6423)
40ce986 
Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com>
This was referenced Oct 19, 2022
Merged
Merged
Merged
Merged
This was referenced Oct 20, 2022
Merged
Merged
@gregaubert gregaubert mentioned this issue Oct 22, 2022
Merged
4 tasks
@AnshumanPadiya AnshumanPadiya mentioned this issue Oct 27, 2022
Merged
4 tasks
This was referenced Oct 28, 2022
Merged
Merged
Merged
@jashanshah33 jashanshah33 mentioned this issue Oct 31, 2022
Merged
@jcfilben jcfilben added good first issue A good one to work on if you are just getting started with grommet and removed hacktoberfest PRs submitted in October (open-source celebration month) labels Nov 9, 2022
gigichan212 added a commit to gigichan212/grommet that referenced this issue Nov 22, 2022
@gigichan212
fixed grommet#6124 issue of insufficient color contrast for Distribut…
1ccc734 
…ion component
@gigichan212 gigichan212 mentioned this issue Nov 22, 2022
Merged
4 tasks
@jcfilben jcfilben reopened this Nov 23, 2022
@hwdsjtu97 hwdsjtu97 mentioned this issue Dec 31, 2022
Merged
4 tasks
UmairAbbas78 added a commit to UmairAbbas78/grommet that referenced this issue May 28, 2023
@UmairAbbas78
Fixed Violation Issues in Footer (grommet#6124) 🚀
70f82d3
jcfilben added a commit that referenced this issue Jun 7, 2023
@UmairAbbas78 @jcfilben
Fixed Footer violations (#6816)
614689f 
* Fixed Footer violations

* Fixed Footer Violations 🚀

* Fixed Violation Issues in Footer (#6124) 🚀

* Fixed minor issues (#6816) ✅

* Changed back to 'brand' in Social Footer ✅✔

* fixed ARIA-ROLE issue ✔

---------

Co-authored-by: Jessica Filben <54560994+jcfilben@users.noreply.github.com>
This was referenced Jul 4, 2023
Merged
Open
UmairAbbas78 added a commit to UmairAbbas78/grommet that referenced this issue Jul 9, 2023
@UmairAbbas78
Fixed violations of NumberEdgePages,NumberMiddlePages,Size,Simple issue(
9e8accf 
grommet#6124)
UmairAbbas78 added a commit to UmairAbbas78/grommet that referenced this issue Jul 9, 2023
@UmairAbbas78
Fixed Violations of NumberEdge,NumberMiddle,Simple,Size Issue(grommet…
fda310b 
…#6124) ✅
UmairAbbas78 added a commit to UmairAbbas78/grommet that referenced this issue Jul 9, 2023
@UmairAbbas78
Fixed Violations of NumberEdge,NumberMiddle,Simple,Size Issue(grommet…
140f361 
…#6124)
UmairAbbas78 added a commit to UmairAbbas78/grommet that referenced this issue Jul 9, 2023
@UmairAbbas78
Fixed Violations of NumberEdge,NumberMiddle,Simple,Size Issue(grommet…
f36cf52 
…#6124)
UmairAbbas78 added a commit to UmairAbbas78/grommet that referenced this issue Jul 12, 2023
@UmairAbbas78
Fixing Violation Issues of Pagination issue(grommet#6124)
4486cdf
@UmairAbbas78 UmairAbbas78 mentioned this issue Jul 12, 2023
Open
UmairAbbas78 added a commit to UmairAbbas78/grommet that referenced this issue Jul 12, 2023
@UmairAbbas78
Fixed Violations of NumberEdge,NumberMiddle,Simple,Size Issue(grommet…
dcfef4c 
…#6124)
@jcfilben jcfilben added the hacktoberfest PRs submitted in October (open-source celebration month) label Sep 19, 2023
This was referenced Oct 10, 2023
Merged
Merged
This was referenced Dec 12, 2023
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility WCAG support good first issue A good one to work on if you are just getting started with grommet hacktoberfest PRs submitted in October (open-source celebration month) help wanted Would appreciate community help working on this
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julieg18 @jcfilben