gulp version bug with the babel register module require #2341

JoshK2 · 2018-10-11T10:05:12Z

gulp do a require to babel register module and failed to load it:
Failed to load external module @babel/register
if you downgrade the version of gulp from 3.9.1 to 3.9.0 its working good.

…#1441) * fix dateTime Icon when format set to 24 H * fix selectPlaceholder prop * fix searchPlaceholder in Select component * add searchPlaceholder to Select component while onSearch is set * provide onSearchPlaceHolder to Select component while onSearch is set * provide onSearchPlaceHolder to Select component while onSearch is set * provide onSearchPlaceHolder to Select component while onSearch is set

Changing the wrapper label of the Radiobutton component for a span tag to meet the WCAG requirement. Upadated the snapshots of the radiobutton. Signed-off-by: jlevesque <jlevesque2109@gmail.com>

* export PasswordInput component in index-common.js Signed-off-by: Jonas Jensen <jonas.jensen@greenbird.com> * export PasswordInput component in index.js Signed-off-by: Jonas Jensen <jonas.jensen@greenbird.com>

* Issue #1436 Changing the wrapper label of the Radiobutton component for a span tag to meet the WCAG requirement. Upadated the snapshots of the radiobutton. Signed-off-by: jlevesque <jlevesque2109@gmail.com> * Moved label tag to wrap the radiobutton, fixing weird clicking issues Signed-off-by: jlevesque <jlevesque2109@gmail.com>

…ence (#1517) Signed-off-by: Jonas Jensen <jonas.jensen@greenbird.com>

Column labels now allow for an optional tuple to define a column header. The first item is just the column label (React node). The second item allows for an options object. This only supports the `sortable` option to disable sorting for some columns. If no options are passed the default is still to rely on the `onSort` value to enable the sorting UI.

* Issue #1436 Changing the wrapper label of the Radiobutton component for a span tag to meet the WCAG requirement. Upadated the snapshots of the radiobutton. Signed-off-by: jlevesque <jlevesque2109@gmail.com> * Moved label tag to wrap the radiobutton, fixing weird clicking issues Signed-off-by: jlevesque <jlevesque2109@gmail.com> * Added French suppport in messages Signed-off-by: jlevesque <jlevesque2109@gmail.com> * Add french support, fixed a typo in the import of fr-FR.js Signed-off-by: jlevesque <jlevesque2109@gmail.com>

* Hide text behind select__control * Prevent error from printing Fix issue #1557 * Remove changes from other PR. oops.

…ributes

…laces, added zoom property, added flag and onHover to series objects. (#1570)

)

* Fixed input border * Fix for #1531 - double border on TextInput * Backed out previous change - due to lint issue * Added changes based on feedback

* Removed prop duration from Toast component to avoid invalid html attributes on prop tranfer * Increased test coverage

…1853) * Header: fixed z-index to make sure body elements go behind the float * Header: fixed z-index to make sure body elements go behind the float * Header: fixed z-index to make sure body elements go behind the float * Header: fixed z-index to make sure body elements go behind the float * Header: fixed z-index to make sure body elements go behind the float pass className to Drop * Header: fixed z-index to make sure body elements go behind the float pass className to Drop * Header: fixed z-index to make sure body elements go behind the float pass className to Drop * Header: fixed z-index to make sure body elements go behind the float pass className to Drop

…et component styling (#2003) * Reorganized SaSS file contents to make it easier to exclude non-grommet component styling * Re-arranged base styles

* Add Github Stale bot * Update stale.yml

Thanks for your contribution!

* When the layer is used in a component that is "observer", and after receiving the new properties (componentDidUpdate), the exit event (keyboard) does not work * Layer bugfix

) * Issue 2109: TextInput - remove keyboard handlers when unmounting. * v.1.11.0 * Added support for class properties in v1. (#2112) * Make handler class property * Update TextInput.js

…et to Grow (#2117)

Adding "defaultMessage" argument to the getMessage function so that the defaultMessage value is not always same as the key argument value which is passed to the getMessage function. Due to the absence of "defaultMessage" argument, developers are forced to keep the value of key argument as what they want the defaultMessage to be shown. Devs want to name their keys in a unique manner and sometimes component specific however the current code restricts it as only key argument is present in the function.

…u drop down in (#2161) If a developer wants to place a Menu within a floating panel (tooltip,etc) its very helpful to constrain the Menu's floating drop down to be rendered in the DOM of the floating parent. This makes life cycle much easier (Menu won't hang around after floating parent is dismissed) and it makes it easier to cause the menu to render within the parent.

#2108) * Issue 2105: Provide infinite scrolling support for moreAbove in the table. Signed-off-by: Robert M. Gary <robert.m.gary@hpe.com> * Adjust spacing * Add tests for infinite scrolling

gulp do a require to babel register module and failed to load it: Failed to load external module @babel/register if you downgrade the version of gulp from 3.9.1 to 3.9.0 its working good.

coveralls · 2018-10-11T10:13:35Z

Coverage remained the same at 25.966% when pulling b39f2d5 on JoshK2:patch-1 into 8181f35 on grommet:master.

alansouzati · 2018-10-11T17:04:56Z

package.json

@@ -65,7 +65,7 @@
    "del": "^3.0.0",
    "eslint": "^4.7.2",
    "grommet-toolbox": "^2.0.0",
-    "gulp": "^3.9.1",
+    "gulp": "^3.9.0",


this will install 3.9.1 right ? since we have the ^ there.

Yes, but this version is failed to load the babel register module

yes I get it. but this PR does not fix this problem since it will install 3.9.1 still right ?

can you get me more details on how to reproduce this issue?

yes, do this:

clone the project

in the terminal run "npm i"

in the terminal run "npm run test"

its output "Failed to load external module @babel/register"
and when i downgrade to gulp version 3.9.0 its work good and output "Requiring external module babel-core/register"

ShimiSun · 2019-02-16T20:32:35Z

Hi @JoshK2, thanks for the PR. will you be willing to address the conflicts?

JoshK2 · 2019-02-28T14:36:30Z

will you be willing to address the conflicts?

The solution that I think worked, seems to not working.
So I don't know how to solve the problem, and I think is not important because I update to version 1.13.0 to use the "hold" grommet and everything working.
You can close the pull request.

przytrzask and others added 30 commits July 21, 2017 12:08

Issue #1436 (#1443)

6bd3a4a

Changing the wrapper label of the Radiobutton component for a span tag to meet the WCAG requirement. Upadated the snapshots of the radiobutton. Signed-off-by: jlevesque <jlevesque2109@gmail.com>

Added PasswordInput component

4d4ebd2

Export passwordinput component (#1446)

e26e7aa

* export PasswordInput component in index-common.js Signed-off-by: Jonas Jensen <jonas.jensen@greenbird.com> * export PasswordInput component in index.js Signed-off-by: Jonas Jensen <jonas.jensen@greenbird.com>

Animate: added onAppear and onLeave callback

af9d659

Fixed Anchor onclick when it is disasbled

c5e5c75

updated test snapshot

ada6c7b

Base input: fixed outline for base input

66d9d27

CheckBox: removing unnecessary aria-label

5109f7e

add translations for /messages, having used en-US.js as base of refer…

323e8a6

…ence (#1517) Signed-off-by: Jonas Jensen <jonas.jensen@greenbird.com>

v1.6.0

84b32fa

Fixed problem where animate inside Split would trigger

b6236b3

Add justify=around prop for setting space-around style (#1357)

8a8760a

Button ctrl click fix (#1561)

530a7b5

* Hide text behind select__control * Prevent error from printing Fix issue #1557 * Remove changes from other PR. oops.

Escape quotes in schema (#1547)

d36c8e0

Hide text behind select__control (#1555)

84fe9ef

TextInput: change onInput to onChange to avoid read-only issues

dee17e1

Toast: removing context props to avoid problems with invalid html att…

0b9795b

…ributes

Tiles: removing timeout for layout when component unmounts

029d049

Updated WorldMap to allow passing props to individual places.

d9f071b

Enhanced WorldMap to support latitude and longitude coordinates for p…

188858b

…laces, added zoom property, added flag and onHover to series objects. (#1570)

Enhanced WorldMap onSelectPlace to also return latitude,longitude (#1576

8fb90c8

)

Menu: fixed problem where the drop would not open sometimes

22ff830

Set type='text' in TextInput (#1577)

5a9c8d6

Fixed input border (#1564)

fa14da9

* Fixed input border * Fix for #1531 - double border on TextInput * Backed out previous change - due to lint issue * Added changes based on feedback

updated lock

66aaa6d

v1.7.0

327c582

Fauricio Rojas Hernández and others added 19 commits February 5, 2018 11:01

Removed prop duration to avoid invalid html attributes for Toast (#1813)

dbdfd2a

* Removed prop duration from Toast component to avoid invalid html attributes on prop tranfer * Increased test coverage

Updated yarn.lock

b334fbe

v1.10.1

90fd7d3

Reorganized SaSS file contents to make it easier to exclude non-gromm…

0301c0d

…et component styling (#2003) * Reorganized SaSS file contents to make it easier to exclude non-grommet component styling * Re-arranged base styles

Add Github Stale bot (#2059)

d5e6ef9

* Add Github Stale bot * Update stale.yml

Update stale.yml

904bc8a

Add dxc minified (#2063)

a15333c

Thanks for your contribution!

FIX #2064 (#2065)

6bf3af7

Layer bugfix (#2067)

8fa2b4e

* When the layer is used in a component that is "observer", and after receiving the new properties (componentDidUpdate), the exit event (keyboard) does not work * Layer bugfix

v.1.11.0

33c6e5d

Added support for class properties in v1. (#2112)

7445b88

Issue 2109: TextInput - remove keyboard handlers when unmounting. (#2111

9d46bab

) * Issue 2109: TextInput - remove keyboard handlers when unmounting. * v.1.11.0 * Added support for class properties in v1. (#2112) * Make handler class property * Update TextInput.js

Updated a selector for the Box used to set flex-basis defaults when s…

c166747

…et to Grow (#2117)

Update stale.yml (#2266)

3cde4a4

Issue 2105: Provide infinite scrolling support for moreAbove in the t… (

8181f35

#2108) * Issue 2105: Provide infinite scrolling support for moreAbove in the table. Signed-off-by: Robert M. Gary <robert.m.gary@hpe.com> * Adjust spacing * Add tests for infinite scrolling

Update gulp version

b39f2d5

gulp do a require to babel register module and failed to load it: Failed to load external module @babel/register if you downgrade the version of gulp from 3.9.1 to 3.9.0 its working good.

JoshK2 changed the title ~~Update gulp version~~ gulp version bug with the babel register module require Oct 11, 2018

alansouzati reviewed Oct 11, 2018

View reviewed changes

alansouzati force-pushed the master branch from ad91740 to c22ab48 Compare November 9, 2018 00:03

ShimiSun added the 1.0 label Jan 2, 2019

ShimiSun added the waiting Awaiting response to latest comments label Feb 24, 2019

ShimiSun closed this Feb 28, 2019

ghost removed the waiting Awaiting response to latest comments label Feb 28, 2019

JoshK2 deleted the patch-1 branch February 28, 2019 15:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gulp version bug with the babel register module require #2341

gulp version bug with the babel register module require #2341

JoshK2 commented Oct 11, 2018

coveralls commented Oct 11, 2018

alansouzati Oct 11, 2018

JoshK2 Oct 11, 2018 •

edited

alansouzati Oct 11, 2018

alansouzati Oct 11, 2018

JoshK2 Oct 13, 2018

ShimiSun commented Feb 16, 2019

JoshK2 commented Feb 28, 2019

gulp version bug with the babel register module require #2341

gulp version bug with the babel register module require #2341

Conversation

JoshK2 commented Oct 11, 2018

coveralls commented Oct 11, 2018

alansouzati Oct 11, 2018

Choose a reason for hiding this comment

JoshK2 Oct 11, 2018 • edited

Choose a reason for hiding this comment

alansouzati Oct 11, 2018

Choose a reason for hiding this comment

alansouzati Oct 11, 2018

Choose a reason for hiding this comment

JoshK2 Oct 13, 2018

Choose a reason for hiding this comment

ShimiSun commented Feb 16, 2019

JoshK2 commented Feb 28, 2019

JoshK2 Oct 11, 2018 •

edited