update node container for the build process #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShimiSun
changed the title
ericsoderberghp
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test to see if the new container will fetch the missing environment variables of CircleCi.
Currently, the environment variable for the CircleCI chroma build isn't being fetched, and we are using a hardcoded version of node10, while node12 is already out (and it is what I'm using locally).
With this change, I see the environment variables are being fetched properly
Update: After attempting the fix on other PRs, the failure wasn't resolved and the env variables are still missing. I'm trying to troubleshoot why it is working for my PRs but not on others.
Regardless I'm thinking we should consider upgrading our node container.