CheckBox and CheckBoxGroup can accept children now #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com>
… object Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com>
|
Docs should be updated on grommet-site repo since CheckBox and CheckBoxGroup docs have been transitioned to the new format. See grommet/grommet-site#233 for more info |
jcfilben
reviewed
Jul 21, 2021
Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com>
Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com>
Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com>
… into children_checkbox
Signed-off-by: GurkiranSingh <gurkiransinghk@gmail.com>
| @@ -21,6 +21,14 @@ export const doc = (CheckBox) => { | |||
| checked: PropTypes.bool | |||
| .description('Same as React <input checked={} />') | |||
| .defaultValue(false), | |||
| children: PropTypes.func.description( | |||
There was a problem hiding this comment.
This change will now need to be made in https://github.com/grommet/grommet-site/blob/master/src/screens/CheckBox.js
| @@ -13,6 +13,15 @@ export const doc = CheckBoxGroup => { | |||
| .intrinsicElement('div'); | |||
|
|
|||
| DocumentedCheckBoxGroup.propTypes = { | |||
| children: PropTypes.func.description( | |||
There was a problem hiding this comment.
Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com>
ericsoderberghp
approved these changes
Aug 4, 2021
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gurkiran_singh gurkiransinghk@gmail.com
What does this PR do?
CheckBoxandCheckBoxGroupcan accept children nowWhere should the reviewer start?
Components => CheckBox and CheckBoxGroup
What testing has been done on this PR?
Added story
Childrenin bothCheckBoxandCheckBoxGroupHow should this be manually tested?
Using Storybook
Any background context you want to provide?
N/A
What are the relevant issues?
#5221
Screenshots (if appropriate)
N/A
Do the grommet docs need to be updated?
Yes, I already did that
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?
backwards compatiable