Don't apply role="gridcell" to blank days or role="row" to blank week #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halocline
approved these changes
Jul 28, 2021
ericsoderberghp
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes use of role="gridcell" on blank Calendar days and role="row" from weeks that are completely blank to improve experience of screen readers.
Removing "gridcell" on blank days ensures a screen reader user doesn't need to navigate over these days.
The removal of role="row" on blank weeks is needed for screen reader to properly calculate number of rows in a table. If not, a completely blank week will still be included in the row count but not accessible by screen reader which is confusing. For example "Row 1 of 6" where only 5 rows are able to be accessed because on week is empty.
Where should the reviewer start?
src/js/components/Calendar/Calendar.js
What testing has been done on this PR?
Tested with VoiceOver locally.
How should this be manually tested?
Test on showAdjacentDays story with VoiceOver and arrow keys. Should not be able to access blank days.
Any background context you want to provide?
What are the relevant issues?
Closes #5436
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No.
Should this PR be mentioned in the release notes?
Yes. Improved behavior for screen reader users by removing blank days from navigable Calendar days.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.