fix: updates DateInput click behavior #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenderjean
reviewed
Aug 2, 2021
taysea
approved these changes
Aug 13, 2021
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes a bug in the DateInput component (when the date input was clicked 3 times, the calendar didn't open until the user click in somewhere out).
Where should the reviewer start?
DateInput.js
What testing has been done on this PR?
I've tested on a local storybook.
How should this be manually tested?
Run the storybook and check the behavior.
Any background context you want to provide?
What are the relevant issues?
Closes #5481.
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No.
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?
Backwards compatible.