Fix: Remove duplicate menu button when menu forcefully flipped #5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeKingdom
reviewed
Aug 2, 2021
taysea
reviewed
Aug 2, 2021
src/js/components/Menu/Menu.js
Outdated
| @@ -88,6 +88,7 @@ const Menu = forwardRef((props, ref) => { | |||
| // when there's not enough space below DropButton. This state | |||
| // is modified on /Drop/DropContainer.js. | |||
| const [alignControlMirror, setAlignControlMirror] = useState(); | |||
| const shrunk = alignControlMirror === align.top; | |||
There was a problem hiding this comment.
I am wondering about this variable name. Wondering if something like alignTop would make more sense?
There was a problem hiding this comment.
Would initialAlignTop be a good name for this since we made this boolean to check if there was an align.top when starting?
taysea
reviewed
Aug 2, 2021
ericsoderberghp
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks to solve issue #5445.
What does this PR do?
[Still for review] Introduces a boolean to be added to the conditional rendering check of
controlMirrorto see if the menu has shrunk and is being forced to flip vertically, removing the duplicate menu button.Where should the reviewer start?
shrunkonMenu.jsyarn storybookand checkoutMenu/SimplestoryWhat testing has been done on this PR?
Manual testing by observing UI changes on storybook (
Menu/Simple)How should this be manually tested?
Please follow steps in the
Where should the reviewer start?section.Any background context you want to provide?
What are the relevant issues?
#5445
Screenshots (if appropriate)
Do the grommet docs need to be updated?
None needed
Should this PR be mentioned in the release notes?
Nope, just a simple bug fix.
Is this change backwards compatible or is it a breaking change?
Backwards compatible 馃憤