Fix options layer bug #5524
Merged
Fix options layer bug #5524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeKingdom
approved these changes
Aug 11, 2021
ericsoderberghp
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds default values for both
OptionsContextandRootsContextWhere should the reviewer start?
RootsContext.js
OptionsContext.js
What testing has been done on this PR?
Storybook
How should this be manually tested?
Take out
<Grommet/>wrapper to ensure thatLayeris still being rendered correctlyAny background context you want to provide?
There was no default value there was only
undefinedbeing passed through.This default value can be helpful for testing components in isolation without wrapping them.
The default value needs to match what is being passed to the
useContextfor instanceOptionsContextwould expect an object so the default value needs to be an objectWhat are the relevant issues?
closes #5516
Screenshots (if appropriate)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
no
Is this change backwards compatible or is it a breaking change?
backwards compatible