Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options prop to Markdown index.d.ts #5534

Merged
merged 2 commits into from Aug 18, 2021

Conversation

jcfilben
Copy link
Collaborator

What does this PR do?

Added options prop to index.d.ts in the Markdown component

Where should the reviewer start?

What testing has been done on this PR?

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Closes #5470

Screenshots (if appropriate)

Do the grommet docs need to be updated?

no

Should this PR be mentioned in the release notes?

maybe (fixed Typescript compatibility for Markdown component)

Is this change backwards compatible or is it a breaking change?

backwards compatible

@ericsoderberghp ericsoderberghp merged commit 89e8c5f into grommet:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MarkdownProps needs to include the options prop
3 participants