Update pagination hook to account for changing data #5683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM :) |
halocline
reviewed
Oct 13, 2021
halocline
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes adjustments to DataTable and usePagination hook to account for changing datasets that might occur from internal datatable changes such as search.
This ensures that the active page is never greater than the total number of available pages and that the pagination controls are showing based on the length of the adjustedData.
NOTE: Storybook example changed purely to allow for code review. Should be reverted before merging!
Where should the reviewer start?
src/js/utils/pagination.js
What testing has been done on this PR?
Tested with code example provided by #5652 (this is what is temp placed in the "Simple" DataTable story).
How should this be manually tested?
Follow steps outlined in "Steps to reproduce" in #5652 within the storybook example in this PR (Simple DataTable).
Any background context you want to provide?
What are the relevant issues?
Closes #5652
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No.
Should this PR be mentioned in the release notes?
Yes. Fixed DataTable pagination bug regarding dynamic datasets.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.