[TS] Fixed types of Video messages prop and theme prop #5760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfilben
approved these changes
Oct 27, 2021
Comment on lines
+1440
to
+1442
| track?: { | ||
| color?: ColorType; | ||
| }; |
There was a problem hiding this comment.
Note: this is also missing from the docs
There was a problem hiding this comment.
@jcfilben Yes. I've mentioned it in the PR description 👆 I think it will go on a separate PR.
ShimiSun
changed the title
ericsoderberghp
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed types of Video messages prop and theme prop
Where should the reviewer start?
Video/index.d.ts
What testing has been done on this PR?
Local unit tests and storybook tests
How should this be manually tested?
Locally
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Do the grommet docs need to be updated?
we might want to add to the docs the theme prop of video
tracker.scrubber.coloron a separate PR, it is missing from the docs.Should this PR be mentioned in the release notes?
Yes -- in case we want to be descriptive about TS fixes.
Is this change backwards compatible or is it a breaking change?
backwards compatible