Fix InfiniteScroll lastPage calculation #5806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsoderberghp
approved these changes
Nov 16, 2021
taysea
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
InfiniteScroll calculates its lastPage index slightly wrong. This fixes that calculation.
The test snapshot changes are cases where InfiniteScroll really shouldn't have put
a marker div. Most of the cases are pagination enabled (where it doesn't need to
detect that the list is scrolled to the end). The change to the InfiniteScroll snaphot
is a case where it had a number of items that was exactly a multiple of the step
(the main bug this fixes.)
Where should the reviewer start?
InfiniteScroll.js
What testing has been done on this PR?
Storybook plus some special situations with DataTable onUpdate.
How should this be manually tested?
See #5794
Any background context you want to provide?
What are the relevant issues?
Fixes #5794
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Yes
Is this change backwards compatible or is it a breaking change?
This is backwards compatible