add gap to theme for button #5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taysea
reviewed
Jan 21, 2022
taysea
reviewed
Jan 21, 2022
src/js/themes/base.js
Outdated
| @@ -418,6 +418,7 @@ export const generate = (baseSpacing = 24, scale = 6) => { | |||
| }, | |||
| }, | |||
| }, | |||
| // gap: undefined, | |||
There was a problem hiding this comment.
Should the default small from Button.js get moved here to the theme?
There was a problem hiding this comment.
I was debating on this as well and removing from the prop I just wasn't sure
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
…ommet into feat/ButtonThemeGap
ericsoderberghp
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability to change the gap through the theme
Where should the reviewer start?
button.js
What testing has been done on this PR?
tested it using a value in the theme
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
Design System needs a way to change
gapto6pxfor buttons with IconsWhat are the relevant issues?
Screenshots (if appropriate)
Do the grommet docs need to be updated?
yes
Should this PR be mentioned in the release notes?
sure
Is this change backwards compatible or is it a breaking change?
backwards compatible