Feat/position notification #5926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6612/grommet into feat/position-notification
| @@ -1,12 +1,27 @@ | |||
| import * as React from 'react'; | |||
|
|
|||
| export type StatusType = 'critical' | 'warning' | 'normal' | 'unknown'; | |||
| export type PositionType = | |||
There was a problem hiding this comment.
Can we just import LayerPositionType and re-use it here.
ericsoderberghp
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a
positionobject that can be passed in withtoastThis is for when a user is using a
Toastit allows them to have theToastin thetoportop-rightWhere should the reviewer start?
notification.js
What testing has been done on this PR?
storybook
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
In Design-System site we have a placement guidance
This states Place
Toasteither top-center or top-right of the screen.In order for a user to be able to put in the
top-rightwe need to provide a prop.What are the relevant issues?
Needed for Design system
Screenshots (if appropriate)
Do the grommet docs need to be updated?
yes
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible