Fix TextInput scroll issue #5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsoderberghp
approved these changes
Feb 1, 2022
britt6612
approved these changes
Feb 1, 2022
|
LGTM Thanks, Jessica! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where TextInput would jump back up to the most recent hovered option when scrolling.
The fix moves the content in
onClickOutsideto a callback function. Using an arrow function was causing unnecessary re-renders which resulted in the jumping scroll behavior.useCallbackensures the component only re-renders when necessary.Where should the reviewer start?
What testing has been done on this PR?
Tested with TextInput Default suggestion and Custom suggestion stories.
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Closes #4098
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Maybe
Is this change backwards compatible or is it a breaking change?
Backwards compatible