Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ThemeType #6203

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Update ThemeType #6203

merged 3 commits into from
Jul 25, 2022

Conversation

bikutadesign
Copy link
Contributor

card.container is missing extend type

What does this PR do?

Adds the missing extend type to ThemeType.card.container

Any background context you want to provide?

When trying to extend card.hover.container I noticed I wasn't getting the desired results.
Extending card.container worked but introduced type errors.

card.container is missing extend property
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ericsoderberghp ericsoderberghp merged commit 8485f3f into grommet:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants