add formField.checkBox.pad as an option to be handeled in formField #6300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taysea
reviewed
Aug 25, 2022
taysea
reviewed
Aug 25, 2022
|
Can we add a unit test for this? |
taysea
approved these changes
Aug 26, 2022
thank you for the feedback 😄 |
ericsoderberghp
approved these changes
Aug 29, 2022
kernicPanel
added a commit
to openfun/marsha
that referenced
this pull request
Sep 5, 2022
Probably due to a bug in grommet v2.25.2, we must define a checkbox in the formField in our theme. grommet/grommet#6300
1 task
lunika
reviewed
Sep 5, 2022
| @@ -782,6 +782,9 @@ export interface ThemeType { | |||
| margin?: MarginType; | |||
| pad?: PadType; | |||
| }; | |||
| checkBox: { | |||
| pad: PadType; | |||
There was a problem hiding this comment.
Should not be optional like other keys ?
There was a problem hiding this comment.
yes you are correct pushing up a fix now sorry for any inconvenience. Thanks for the catch!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds
formField.checkBox.padthis will addpadto checkbox from theme.Where should the reviewer start?
FormField
What testing has been done on this PR?
set pad value to formField.checkBox.pad
How should this be manually tested?
set pad value to formField.checkBox.pad
Custom story
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
needed for theme
grommet/grommet-theme-hpe#269
Screenshots (if appropriate)
Do the grommet docs need to be updated?
yes I will add a PR if this is the direction we go
Should this PR be mentioned in the release notes?
sure
Is this change backwards compatible or is it a breaking change?
backwards compatible