New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure PaginationSummary reflects active page #7169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, can we add a jest test for this?
…t/grommet into fix/pagination-summary-activepage
Done! And fixed some deprecated assertions as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What does this PR do?
PaginationSummary should always reflect active page. When used outside of Data, the summary wasn't updating when page changed via pagination controls.
Also removed extra space in PaginationStep and updated SpaceX story to demo latest
summary
support.Where should the reviewer start?
src/js/components/Pagination/Pagination.js
What testing has been done on this PR?
Local.
How should this be manually tested?
On "Steps" story, change page and PaginationSummary should update.
Do Jest tests follow these best practices?
screen
is used for querying.asFragment()
is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?
Backwards compatible.